Merge pull request #448 from cloudinary/feature/add-format-quality-alias

Author: strausr

__TESTS__/unit/actions/Delivery.test.ts

@@ -22,6 +22,20 @@ describe('Tests for Transformation Action -- Delivery', () => {
     expect(url).toBe('https://res.cloudinary.com/demo/image/upload/f_auto/sample');
   });
 
+  it('Creates a cloudinaryURL with quality alias', () => {
+    const url = createNewImage('sample')
+      .quality('auto')
+      .toURL();
+    expect(url).toBe('https://res.cloudinary.com/demo/image/upload/q_auto/sample');
+  });
+
+  it('Creates a cloudinaryURL with format alias', () => {
+    const url = createNewImage('sample')
+      .format('gif')
+      .toURL();
+    expect(url).toBe('https://res.cloudinary.com/demo/image/upload/f_gif/sample');
+  });
+
   it('Creates a cloudinaryURL with Format', () => {
     const url = createNewImage('sample')
       .delivery(format(Format.gif()))

__TESTS__/unit/actions/Quality.test.ts

@@ -5,14 +5,6 @@ import {createNewImage} from "../../TestUtils/createCloudinaryImage";
 
 
 describe('Tests for Transformation Action -- Delivery.quality', () => {
-  it('Ensures auto is accepted as an action to ImageTransformation', () => {
-    const tImage = createNewImage();
-    // Ensures it compiles and doesn't throw
-    expect(
-      tImage.quality(Delivery.quality('80'))
-    ).toEqual(tImage);
-  });
-
   it('Creates a cloudinaryURL with quality', () => {
     const url = createNewImage('sample')
       .delivery(Delivery.quality(Quality.auto()))

src/assets/CloudinaryTransformable.ts

@@ -25,6 +25,7 @@ import {IAdjustAction} from "../actions/adjust.js";
 import {DeliveryQualityAction} from "../actions/delivery/DeliveryQuality.js";
 import {ITrackedPropertiesThroughAnalytics} from "../sdkAnalytics/interfaces/ITrackedPropertiesThroughAnalytics.js";
 import {AnimatedAction} from "../actions/animated.js";
+import {DeliveryFormat} from "../actions/delivery/DeliveryFormat.js";
 
 /**
  * @desc Cloudinary Transformable interface, extended by any class that needs a Transformation Interface
@@ -80,12 +81,22 @@ class CloudinaryTransformable extends CloudinaryFile {
   }
 
   /**
-   * @desc A proxy to {@link SDK.Transformation| Transformation} - Calls the same method contained in this.transformation
-   * @param {Actions.Delivery} quality
+   * @desc An alias to Action Delivery.quality
+   * @param {string|number} quality
+   * @return {this}
+   */
+  quality(quality: string|number): this {
+    this.addAction(new DeliveryFormat('q', quality));
+    return this;
+  }
+
+  /**
+   * @desc An alias to Action Delivery.format
+   * @param {string} format
    * @return {this}
    */
-  quality(quality: DeliveryQualityAction): this {
-    this.transformation.quality(quality);
+  format(format: string): this {
+    this.addAction(new DeliveryFormat('f', format));
     return this;
   }