Skip to content

Commit af95846

Browse files
author
Nir Maoz
authored
Add explanation why we don't add analytics when publicId includes a '?' (#484)
1 parent 8b1a683 commit af95846

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/assets/CloudinaryFile.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,8 @@ class CloudinaryFile {
283283
.replace(/\?/g, '%3F')
284284
.replace(/=/g, '%3D');
285285

286-
// True by default, has to be explicitly set to false to overwrite
286+
// urlConfig.analytics is true by default, has to be explicitly set to false to overwrite
287+
// Don't add analytics when publicId includes a '?' to not risk changing existing query params
287288
if (this.urlConfig.analytics !== false && !(publicID.includes('?'))) {
288289
return `${safeURL}?_a=${getSDKAnalyticsSignature(trackedAnalytics)}`;
289290
} else {

0 commit comments

Comments
 (0)