diff --git a/src/Api/Upload/UploadTrait.php b/src/Api/Upload/UploadTrait.php index e4cc5022..fa421ca9 100644 --- a/src/Api/Upload/UploadTrait.php +++ b/src/Api/Upload/UploadTrait.php @@ -56,6 +56,7 @@ public static function buildUploadParams($options) 'eager_async', 'eager_notification_url', 'eval', + 'on_success', 'exif', 'faces', 'filename_override', diff --git a/tests/Integration/IntegrationTestCase.php b/tests/Integration/IntegrationTestCase.php index f3144d97..33390236 100644 --- a/tests/Integration/IntegrationTestCase.php +++ b/tests/Integration/IntegrationTestCase.php @@ -44,10 +44,11 @@ abstract class IntegrationTestCase extends CloudinaryTestCase const TEST_DOCX_PATH = self::TEST_ASSETS_DIR . AssetTestCase::DOCX_NAME; const TEST_VIDEO_PATH = self::TEST_ASSETS_DIR . AssetTestCase::VIDEO_NAME; const TEST_LOGGING = ['logging' => ['test' => ['level' => 'debug']]]; - const TEST_EVAL_STR - = 'if (resource_info["width"] < 450) { upload_options["quality_analysis"] = true }; ' . + const TEST_EVAL_STR = 'if (resource_info["width"] < 450) { upload_options["quality_analysis"] = true }; ' . 'upload_options["context"] = "width=" + resource_info["width"]'; + const TEST_ON_SUCCESS_STR = 'current_asset.update({tags: ["autocaption"]});'; + private static $TEST_ASSETS = []; protected static $UNIQUE_UPLOAD_PRESET; diff --git a/tests/Unit/Upload/UploadApiTest.php b/tests/Unit/Upload/UploadApiTest.php index 34ce8dc2..6063095f 100644 --- a/tests/Unit/Upload/UploadApiTest.php +++ b/tests/Unit/Upload/UploadApiTest.php @@ -15,6 +15,7 @@ use Cloudinary\Configuration\Configuration; use Cloudinary\Test\Helpers\MockUploadApi; use Cloudinary\Test\Helpers\RequestAssertionsTrait; +use Cloudinary\Test\Integration\IntegrationTestCase; use Cloudinary\Test\Unit\Asset\AssetTestCase; /** @@ -38,6 +39,7 @@ public function testVariousUploadParams() 'cinemagraph_analysis' => true, 'media_metadata' => true, 'visual_search' => true, + 'on_success' => IntegrationTestCase::TEST_ON_SUCCESS_STR, ]; $mockUploadApi = new MockUploadApi(); @@ -49,7 +51,7 @@ public function testVariousUploadParams() $lastOptions = $mockUploadApi->getApiClient()->getRequestMultipartOptions(); foreach ($params as $param => $value) { - self::assertEquals($value ? '1' : '0', $lastOptions[$param]); + self::assertEquals(is_bool($value) ? $value ? '1' : '0': $value, $lastOptions[$param]); } }