Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] pollForProcessingImage, Util v4 #51

Open
colbyfayock opened this issue Oct 17, 2024 · 1 comment
Open

[Feature] pollForProcessingImage, Util v4 #51

colbyfayock opened this issue Oct 17, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@colbyfayock
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

pollForProcessingImage now returns an object instead of a simple boolean. This would be considered a breaking change as the error handling may rely on that falsy response.

export interface PollForProcessingImageResponse {
  status: number;
  success: boolean;
  error?: string;
}

https://github.com/cloudinary-community/cloudinary-util/pull/213/files#diff-77ed4ecc8d07c6f02f55f6988e3c43916f9bbeea319039f9594b01820ce844f4R163-R167

the goal of that work is to provide additional context of an error, so for instance, you can log the error in development context, like this:

cloudinary-community/next-cloudinary#553

@colbyfayock colbyfayock added the help wanted Extra attention is needed label Oct 17, 2024
@RS-labhub
Copy link

RS-labhub commented Nov 10, 2024

Hey, I want to work on this... May I?

Edit: mentioned @colbyfayock

I'm unable to see PollForProcessingImageResponse in https://github.com/cloudinary-community/astro-cloudinary/blob/main/astro-cloudinary/src/lib/cloudinary.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants