Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Update detect-new-version-and-upload-artifacts task packaging logic for PHP #246

Open
brayanhenao opened this issue Mar 8, 2023 · 0 comments

Comments

@brayanhenao
Copy link
Member

Context

This task interacts with both Gemfiles (buildpacks-ci and the buildpack that is being packaged) in the case in which the Buildpack is packaged with buildpack-packager. This only happens with PHP right now since is the only buildpack that uses the old package logic.

On cloudfoundry/php-buildpack#815 we updated the PHP Buildpack Gemfile required Ruby version to 3.0. Now that the detect-and-upload task runs for the PHP Buildpack, it fails because of the ruby version used in the cfbuildpacks/ci image on which the task is being run.

Temporary solution

In #245 we updated the task to download the old PHP Gemfile (Ruby 2) just to install and package the buildpack. This should be changed once bionic/cflinuxfs3 is deprecated and the ci image/buildpacks-ci dockerfile is updated.

@brayanhenao brayanhenao changed the title [Tech Debt] Update detect-and-upload packaging logic for PHP [Tech Debt] Update detect-new-version-and-upload-artifacts task packaging logic for PHP Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Not scoped
Development

No branches or pull requests

2 participants