Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Id Device Path Resolver logic in the agent #298

Open
jpalermo opened this issue Aug 24, 2023 · 0 comments
Open

Update Id Device Path Resolver logic in the agent #298

jpalermo opened this issue Aug 24, 2023 · 0 comments

Comments

@jpalermo
Copy link
Member

The current logic is very rigid and inflexible: https://github.com/cloudfoundry/bosh-agent/blob/232da0ab1cbc633351996a52f34424f5989e54c9/infrastructure/devicepathresolver/id_device_path_resolver.go#L71-L97

We've run into problems where the disk id on Openstack is often truncated to 20 characters, but newer versions of Openstack may have the full disk id. This makes it impossible using the current logic for the CPI or the Agent to make the correct decision.

It would be better if the stemcell could provide a list of transformations to try in a preferred order and the agent smartly chooses the best match.

This is a bit tricky because you have to be careful of the partitions that are also listed in /dev/disk/by-id as well as the current retry logic which might make it difficult to be sure you are using the correct matching pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting for Changes | Open for Contribution
Development

No branches or pull requests

1 participant