Stop using deprecated ioutil package

Author: geofffranks

client.go

@@ -5,7 +5,7 @@ import (
 	"crypto/tls"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"mime"
 	"net"
 	"net/http"
@@ -990,7 +990,7 @@ func handleProtoResponse(response *http.Response, responseObject proto.Message)
 		return models.NewError(models.Error_InvalidRequest, "responseObject cannot be nil")
 	}
 
-	buf, err := ioutil.ReadAll(response.Body)
+	buf, err := io.ReadAll(response.Body)
 	if err != nil {
 		return models.NewError(models.Error_InvalidResponse, fmt.Sprint("failed to read body: ", err.Error()))
 	}

cmd/bbs/config/config_test.go

@@ -1,7 +1,6 @@
 package config_test
 
 import (
-	"io/ioutil"
 	"os"
 	"time"
 
@@ -88,7 +87,7 @@ var _ = Describe("BBSConfig", func() {
 	})
 
 	JustBeforeEach(func() {
-		configFile, err := ioutil.TempFile("", "config-file")
+		configFile, err := os.CreateTemp("", "config-file")
 		Expect(err).NotTo(HaveOccurred())
 
 		n, err := configFile.WriteString(configData)

cmd/bbs/main_suite_test.go

@@ -3,7 +3,7 @@ package main_test
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"log"
 	"net"
 	"net/http"
@@ -83,7 +83,7 @@ var _ = SynchronizedBeforeSuite(
 		return []byte(strings.Join([]string{bbsPath, locketPath}, ","))
 	},
 	func(binPaths []byte) {
-		grpclog.SetLogger(log.New(ioutil.Discard, "", 0))
+		grpclog.SetLogger(log.New(io.Discard, "", 0))
 		startPort := 1050 * GinkgoParallelProcess()
 		portRange := 1000
 		var err error

cmd/bbs/testrunner/runner.go

@@ -2,7 +2,6 @@ package testrunner
 
 import (
 	"encoding/json"
-	"io/ioutil"
 	"os"
 	"os/exec"
 	"time"
@@ -19,7 +18,7 @@ func New(binPath string, bbsConfig config.BBSConfig) *ginkgomon.Runner {
 		bbsConfig.ReportInterval = durationjson.Duration(time.Minute)
 	}
 
-	f, err := ioutil.TempFile("", "bbs.config")
+	f, err := os.CreateTemp("", "bbs.config")
 	Expect(err).NotTo(HaveOccurred())
 
 	err = json.NewEncoder(f).Encode(bbsConfig)

db/sqldb/fakesqldriver/fakesqldriver_suite_test.go

@@ -17,7 +17,7 @@ import (
 	"code.cloudfoundry.org/clock/fakeclock"
 	mfakes "code.cloudfoundry.org/diego-logging-client/testhelpers"
 	"code.cloudfoundry.org/lager/v3/lagertest"
-	"github.com/nu7hatch/gouuid"
+	uuid "github.com/nu7hatch/gouuid"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 

db/sqldb/helpers/connection_string.go

@@ -4,7 +4,7 @@ import (
 	"crypto/tls"
 	"crypto/x509"
 	"database/sql"
-	"io/ioutil"
+	"os"
 	"strconv"
 	"time"
 
@@ -99,7 +99,7 @@ func generateTLSConfig(logger lager.Logger, sqlCACertPath string, sqlEnableIdent
 		return tlsConfig
 	}
 
-	certBytes, err := ioutil.ReadFile(sqlCACertPath)
+	certBytes, err := os.ReadFile(sqlCACertPath)
 	if err != nil {
 		logger.Fatal("failed-to-read-sql-ca-file", err)
 	}

handlers/handlers.go

@@ -1,7 +1,7 @@
 package handlers
 
 import (
-	"io/ioutil"
+	"io"
 	"net/http"
 	"strconv"
 
@@ -152,7 +152,7 @@ func route(f http.HandlerFunc) http.Handler {
 }
 
 func parseRequest(logger lager.Logger, req *http.Request, request MessageValidator) error {
-	data, err := ioutil.ReadAll(req.Body)
+	data, err := io.ReadAll(req.Body)
 	if err != nil {
 		logger.Error("failed-to-read-body", err)
 		return models.ErrUnknownError

metrics/file_descriptor_metron_notifier.go

@@ -1,7 +1,6 @@
 package metrics
 
 import (
-	"io/ioutil"
 	"os"
 
 	"github.com/tedsuo/ifrit"
@@ -62,7 +61,7 @@ func (notifier FileDescriptorMetronNotifier) Run(signals <-chan os.Signal, ready
 }
 
 func (notifier FileDescriptorMetronNotifier) descriptorCount() (int, error) {
-	descriptorInfos, err := ioutil.ReadDir(notifier.procFSPath)
+	descriptorInfos, err := os.ReadDir(notifier.procFSPath)
 
 	if err != nil {
 		return 0, err

metrics/file_descriptor_metron_notifier_test.go

@@ -1,7 +1,6 @@
 package metrics_test
 
 import (
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"strconv"
@@ -32,10 +31,10 @@ var _ = Describe("FileDescriptorMetronNotifier", func() {
 	)
 
 	BeforeEach(func() {
-		fakeProcFileSystemPath, err = ioutil.TempDir("", "proc")
+		fakeProcFileSystemPath, err = os.MkdirTemp("", "proc")
 		Expect(err).NotTo(HaveOccurred())
 
-		symlinkedFileDir, err = ioutil.TempDir("", "tmpdir")
+		symlinkedFileDir, err = os.MkdirTemp("", "tmpdir")
 		Expect(err).NotTo(HaveOccurred())
 
 		fakeMetronClient = new(mfakes.FakeIngressClient)
@@ -113,7 +112,7 @@ var _ = Describe("FileDescriptorMetronNotifier", func() {
 })
 
 func createSymlink(dir, tmpdir, symlinkId string) {
-	fd, err := ioutil.TempFile(tmpdir, "socket")
+	fd, err := os.CreateTemp(tmpdir, "socket")
 	Expect(err).NotTo(HaveOccurred())
 	symlink := filepath.Join(dir, symlinkId)