Add metric tags to desired lrp update (#51)

* Use counterfeiter directives to generate fakes

Replace go generate tags with counterfeiter directives to speed up the
generation of fakes and remove warning messages from stderr.

Co-authored-by: Carson Long <[email protected]>

* Regenerate models with protoc v3.21.10

Co-authored-by: Andrew Crump <[email protected]>

* Remove unused import from certificate properties proto

protoc version is v3.21.10.

Resolves the following warning that we were seeing during go generate:
```
certificate_properties.proto:5:1: warning: Import github.com/gogo/protobuf/gogoproto/gogo.proto is unused.
```

Co-authored-by: Carson Long <[email protected]>

* Add metric tags to DesiredLRPUpdate

cloudfoundry/diego-release#662

Co-authored-by: Andrew Crump <[email protected]>

* Persist metric tags on Desired LRP Update

- Overwrite any existing metric tags.
- If metric tags are not provided in the message then don't update them.
- We don't believe that CreatedAt is in use anymore, we believe we are
  ok to pass in db.clock.Now() when re-generating the RunInfo.

cloudfoundry/diego-release#662

Co-authored-by: Carson Long <[email protected]>

* Remove CreateComponents from DesiredLRP

We don't believe that this has been in use since the removal of ETCD in
09fd338.

Co-authored-by: Andrew Crump <[email protected]>

* New revision of UpdateDesiredLRP

- Adds UpdateDesiredLRP_r1 with support for metric tags
- UpdateDesiredLRP_r0 ignores the metric tags field if provided

cloudfoundry/diego-release#662

Signed-off-by: Rebecca Roberts <[email protected]>

* Document update desired LRP r1

cloudfoundry/diego-release#662

Co-authored-by: Andrew Crump <[email protected]>

* Remove redundant type information

* Add metric tags to example DesiredLRPUpdateRequest

cloudfoundry/diego-release#662

* Revert revision bump of desired lrp update endpoint

Reverts the following commits:
- 1e131b5
- feeab5a

cloudfoundry/diego-release#662

Co-authored-by: Andrew Crump <[email protected]>

Signed-off-by: Rebecca Roberts <[email protected]>
Co-authored-by: Carson Long <[email protected]>
Co-authored-by: Rebecca Roberts <[email protected]>

Author: 3 people

client.go

@@ -35,8 +35,10 @@ const (
 
 var EndpointNotFoundErr = models.NewError(models.Error_InvalidResponse, fmt.Sprintf(InvalidResponseMessage, 404))
 
-//go:generate counterfeiter -o fake_bbs/fake_internal_client.go . InternalClient
-//go:generate counterfeiter -o fake_bbs/fake_client.go . Client
+//go:generate counterfeiter -generate
+
+//counterfeiter:generate -o fake_bbs/fake_internal_client.go . InternalClient
+//counterfeiter:generate -o fake_bbs/fake_client.go . Client
 
 /*
 The InternalClient interface exposes all available endpoints of the BBS server,
@@ -154,7 +156,7 @@ type ExternalActualLRPClient interface {
 }
 
 /*
-The ExternalDesiredLRPClient is used to access and manipulate Disired LRPs.
+The ExternalDesiredLRPClient is used to access and manipulate Desired LRPs.
 */
 type ExternalDesiredLRPClient interface {
 	// Lists all DesiredLRPs that match the given DesiredLRPFilter

controllers/lrp_convergence_controller.go

@@ -17,7 +17,9 @@ import (
 	"code.cloudfoundry.org/workpool"
 )
 
-//go:generate counterfeiter -o fakes/fake_retirer.go . Retirer
+//go:generate counterfeiter -generate
+
+//counterfeiter:generate -o fakes/fake_retirer.go . Retirer
 type Retirer interface {
 	RetireActualLRP(ctx context.Context, logger lager.Logger, key *models.ActualLRPKey) error
 }

converger/converger.go

@@ -14,12 +14,14 @@ import (
 	"code.cloudfoundry.org/clock"
 )
 
-//go:generate counterfeiter -o fake_controllers/fake_lrp_convergence_controller.go . LrpConvergenceController
+//go:generate counterfeiter -generate
+
+//counterfeiter:generate -o fake_controllers/fake_lrp_convergence_controller.go . LrpConvergenceController
 type LrpConvergenceController interface {
 	ConvergeLRPs(ctx context.Context, logger lager.Logger)
 }
 
-//go:generate counterfeiter -o fake_controllers/fake_task_controller.go . TaskController
+//counterfeiter:generate -o fake_controllers/fake_task_controller.go . TaskController
 type TaskController interface {
 	ConvergeTasks(ctx context.Context, logger lager.Logger, kickTaskDuration, expirePendingTaskDuration, expireCompletedTaskDuration time.Duration) error
 }

db/actual_lrp_db.go

@@ -7,7 +7,7 @@ import (
 	"code.cloudfoundry.org/lager"
 )
 
-//go:generate counterfeiter . ActualLRPDB
+//counterfeiter:generate . ActualLRPDB
 
 type ActualLRPDB interface {
 	ActualLRPs(ctx context.Context, logger lager.Logger, filter models.ActualLRPFilter) ([]*models.ActualLRP, error)

db/db.go

@@ -1,6 +1,8 @@
 package db
 
-//go:generate counterfeiter . DB
+//go:generate counterfeiter -generate
+
+//counterfeiter:generate . DB
 
 type DB interface {
 	DomainDB

db/desired_lrp_db.go

@@ -7,7 +7,7 @@ import (
 	"code.cloudfoundry.org/lager"
 )
 
-//go:generate counterfeiter . DesiredLRPDB
+//counterfeiter:generate . DesiredLRPDB
 
 type DesiredLRPDB interface {
 	DesiredLRPs(ctx context.Context, logger lager.Logger, filter models.DesiredLRPFilter) ([]*models.DesiredLRP, error)

db/domain_db.go

@@ -6,7 +6,7 @@ import (
 	"code.cloudfoundry.org/lager"
 )
 
-//go:generate counterfeiter . DomainDB
+//counterfeiter:generate . DomainDB
 type DomainDB interface {
 	FreshDomains(ctx context.Context, logger lager.Logger) ([]string, error)
 	UpsertDomain(ctx context.Context, lgger lager.Logger, domain string, ttl uint32) error

db/encryption_db.go

@@ -6,7 +6,7 @@ import (
 	"code.cloudfoundry.org/lager"
 )
 
-//go:generate counterfeiter . EncryptionDB
+//counterfeiter:generate . EncryptionDB
 
 type EncryptionDB interface {
 	EncryptionKeyLabel(ctx context.Context, logger lager.Logger) (string, error)

db/evacuation_db.go

@@ -7,7 +7,7 @@ import (
 	"code.cloudfoundry.org/lager"
 )
 
-//go:generate counterfeiter . EvacuationDB
+//counterfeiter:generate . EvacuationDB
 
 type EvacuationDB interface {
 	RemoveEvacuatingActualLRP(context.Context, lager.Logger, *models.ActualLRPKey, *models.ActualLRPInstanceKey) error

db/lrp_db.go

@@ -14,7 +14,7 @@ type ActualLRPKeyWithInternalRoutes struct {
 	DesiredInternalRoutes internalroutes.InternalRoutes
 }
 
-//go:generate counterfeiter . LRPDB
+//counterfeiter:generate . LRPDB
 
 type ConvergenceResult struct {
 	MissingLRPKeys               []*models.ActualLRPKeyWithSchedulingInfo