Merge pull request #3969 from cloudfoundry/fix_log-level-ignorance

joergdw · web-flow · commit 2c95f0d993b3 · 2025-10-23T16:13:09.000+02:00
🔧 Fix: Set log-level for text-sinks.
diff --git a/src/autoscaler/helpers/logger.go b/src/autoscaler/helpers/logger.go
@@ -22,7 +22,7 @@ func InitLoggerFromConfig(conf *LoggingConfig, name string) lager.Logger {
 	logger := lager.NewLogger(name)
 
 	if conf.PlainTextSink {
-		plaintextFormatSink := createPlaintextSink()
+		plaintextFormatSink := createPlaintextSink(logLevel)
 		logger.RegisterSink(plaintextFormatSink)
 	} else {
 		redactedSink := createRedactedSink(logLevel)
@@ -47,9 +47,11 @@ func parseLogLevel(level string) (lager.LogLevel, error) {
 	}
 }
 
-func createPlaintextSink() lager.Sink {
+func createPlaintextSink(logLevel lager.LogLevel) lager.Sink {
 	slogger := slog.New(slog.NewTextHandler(os.Stdout, nil))
-	return lager.NewSlogSink(slogger)
+	slogSink := lager.NewSlogSink(slogger)
+	withMinLevelConfig := lager.NewReconfigurableSink(slogSink, logLevel)
+	return withMinLevelConfig
 }
 
 func createRedactedSink(logLevel lager.LogLevel) lager.Sink {

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ func InitLoggerFromConfig(conf *LoggingConfig, name string) lager.Logger {`
`22`	`22`	`logger := lager.NewLogger(name)`
`23`	`23`
`24`	`24`	`if conf.PlainTextSink {`
`25`		`- plaintextFormatSink := createPlaintextSink()`
	`25`	`+ plaintextFormatSink := createPlaintextSink(logLevel)`
`26`	`26`	`logger.RegisterSink(plaintextFormatSink)`
`27`	`27`	`} else {`
`28`	`28`	`redactedSink := createRedactedSink(logLevel)`
`@@ -47,9 +47,11 @@ func parseLogLevel(level string) (lager.LogLevel, error) {`
`47`	`47`	`}`
`48`	`48`	`}`
`49`	`49`
`50`		`-func createPlaintextSink() lager.Sink {`
	`50`	`+func createPlaintextSink(logLevel lager.LogLevel) lager.Sink {`
`51`	`51`	`slogger := slog.New(slog.NewTextHandler(os.Stdout, nil))`
`52`		`- return lager.NewSlogSink(slogger)`
	`52`	`+ slogSink := lager.NewSlogSink(slogger)`
	`53`	`+ withMinLevelConfig := lager.NewReconfigurableSink(slogSink, logLevel)`
	`54`	`+ return withMinLevelConfig`
`53`	`55`	`}`
`54`	`56`
`55`	`57`	`func createRedactedSink(logLevel lager.LogLevel) lager.Sink {`