Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question : Filter for deployments #162

Open
rcpnair opened this issue Mar 11, 2019 · 5 comments
Open

Question : Filter for deployments #162

rcpnair opened this issue Mar 11, 2019 · 5 comments
Assignees

Comments

@rcpnair
Copy link

rcpnair commented Mar 11, 2019

We have multiple deployments (tiles) in the foundation for e.g. PAS, REDIS, RMQ, Health Watch etc and would like to source data only from PAS related deployment (cf). Currently the nozzle extracts information from all tiles/deployments for the configured event type(e.g. CounterEvent).
Is it possible to filter by deployment name from the source itself similar to event type?

@luckyj5 luckyj5 self-assigned this Mar 13, 2019
@luckyj5
Copy link
Collaborator

luckyj5 commented May 4, 2019

@rcpnair Currently filtering by deployment name is not available within the nozzle. Eventtype (CounterEvent) is part of the event channel which comes from Firehose Loggregator and Splunk nozzle just maps the CounterEvent eventtype to cf:counterevent sourcetype in Splunk.
Please let me know if any questions. Thanks!

@luckyj5 luckyj5 added this to the v1.1 milestone May 4, 2019
@luckyj5 luckyj5 added the wontfix label May 4, 2019
@rcpnair
Copy link
Author

rcpnair commented May 15, 2019

@luckyj5 ,
Deployment name is available in the envelop.
I have tried something similar and works fine.

func (r *router) Route(msg *events.Envelope) error {

	deployment := msg.GetDeployment()

	if ! (r.selectedDeployments["all"]) &&  ! (r.selectedDeployments[deployment]) {
		return nil
	}

Configuration and selectedDeployments are similar to event type filtering.

@luckyj5 luckyj5 removed the wontfix label May 16, 2019
@luckyj5
Copy link
Collaborator

luckyj5 commented May 16, 2019

@rcpnair Thanks for the update and testing it out.
It would be great if you can raise a PR against develop branch with your suggested changes (please add required tests) and will review it during the next maintenance window. Please let me know if any questions. Thanks!

@rcpnair
Copy link
Author

rcpnair commented May 23, 2019

@luckyj5 , Thanks . PR has been created ( #175)

@luckyj5 luckyj5 removed this from the v1.1 milestone Jun 8, 2019
@lcasey-aarp
Copy link

Would like to see this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants