fix: correct isinstance check to include bytearray in kafka conversion (#267)

archy-rock3t-cloud · claude · web-flow · commit 47b02d1e6e10 · 2026-03-07T19:12:35.000+01:00
The isinstance check in to_structured had a duplicate `bytes` entry
instead of `bytearray`, meaning bytearray data would not be correctly
base64-encoded in the structured kafka message.

Signed-off-by: Artem Muterko &lt;artem@sopho.tech&gt;
Co-authored-by: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/cloudevents/v1/kafka/conversion.py b/src/cloudevents/v1/kafka/conversion.py
@@ -183,7 +183,7 @@ def to_structured(
         raise cloud_exceptions.DataMarshallerError(
             f"Failed to marshall data with error: {type(e).__name__}('{e}')"
         )
-    if isinstance(data, (bytes, bytes, memoryview)):
+    if isinstance(data, (bytes, bytearray, memoryview)):
         attrs["data_base64"] = base64.b64encode(data).decode("ascii")
     else:
         attrs["data"] = data

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ def to_structured(`
`183`	`183`	`raise cloud_exceptions.DataMarshallerError(`
`184`	`184`	`f"Failed to marshall data with error: {type(e).__name__}('{e}')"`
`185`	`185`	`)`
`186`		`- if isinstance(data, (bytes, bytes, memoryview)):`
	`186`	`+ if isinstance(data, (bytes, bytearray, memoryview)):`
`187`	`187`	`attrs["data_base64"] = base64.b64encode(data).decode("ascii")`
`188`	`188`	`else:`
`189`	`189`	`attrs["data"] = data`