Empty Database not generating an execute sql file. #98

Author: dstreev

dependency-reduced-pom.xml

@@ -4,7 +4,7 @@
   <groupId>com.cloudera.utils.hadoop</groupId>
   <artifactId>hms-mirror</artifactId>
   <name>hms-mirror</name>
-  <version>1.6.5.9-SNAPSHOT</version>
+  <version>1.6.5.10-SNAPSHOT</version>
   <url>https://github.com/cloudera-labs/hms_mirror</url>
   <build>
     <finalName>${project.artifactId}</finalName>

pom.xml

@@ -22,7 +22,7 @@
 
     <groupId>com.cloudera.utils.hadoop</groupId>
     <artifactId>hms-mirror</artifactId>
-    <version>1.6.5.9-SNAPSHOT</version>
+    <version>1.6.5.10-SNAPSHOT</version>
     <name>hms-mirror</name>
 
     <url>https://github.com/cloudera-labs/hms_mirror</url>

src/main/java/com/cloudera/utils/hadoop/hms/mirror/Conversion.java

@@ -78,6 +78,7 @@ public String executeSql(Environment environment, String database) {
             for (Pair sqlPair : dbSql) {
                 sb.append("-- ").append(sqlPair.getDescription()).append("\n");
                 sb.append(sqlPair.getAction()).append(";\n");
+                found = Boolean.TRUE;
             }
         }
 

src/main/java/com/cloudera/utils/hadoop/hms/mirror/StatsCalculator.java

@@ -175,7 +175,7 @@ public static void setSessionOptions(Cluster cluster, EnvironmentTable controlEn
     }
 
     private static SerdeType serdeFromStats(Map<String, Object> stats) {
-        String sStype = stats.get(FILE_FORMAT).toString();
+        String sStype = stats.getOrDefault(FILE_FORMAT, "UNKNOWN").toString();
         SerdeType serdeType = null;
         if (sStype == null) {
             serdeType = SerdeType.UNKNOWN;

src/test/java/com/cloudera/utils/hadoop/hms/EndToEndLegacyToCDPTest.java

@@ -1085,6 +1085,10 @@ public void so_ro() {
         Mirror mirror = new Mirror();
         long rtn = mirror.go(args);
         long check = MessageCode.RO_DB_DOESNT_EXIST.getLong();
+
+        // TODO: Current testing doesn't have ability to check a filesystem, which this test relies on.
+        // This test is expected to fail at this point.
+
         assertEquals("Return Code Failure: " + rtn + " doesn't match: " + check * -1, check * -1, rtn);
 
     }
@@ -1109,6 +1113,8 @@ public void so_ro_sync() {
         rtn = mirror.go(args);
         long check = MessageCode.RO_DB_DOESNT_EXIST.getLong();
 
+        // TODO: Current testing doesn't have ability to check a filesystem, which this test relies on.
+        // This test is expected to fail at this point.
         assertEquals("Return Code Failure: " + rtn + " doesn't match: " + check * -1, check * -1, rtn);
 
     }
@@ -1133,7 +1139,8 @@ public void so_ro_tf() {
         Mirror mirror = new Mirror();
         rtn = mirror.go(args);
         long check = MessageCode.RO_DB_DOESNT_EXIST.getLong();
-
+        // TODO: Current testing doesn't have ability to check a filesystem, which this test relies on.
+        // This test is expected to fail at this point.
         assertEquals("Return Code Failure: " + rtn + " doesn't match: " + check * -1, check * -1, rtn);
 
     }
@@ -2079,7 +2086,8 @@ public void sql_ro() {
         rtn = mirror.go(args);
         // Should fail because DB dir doesn't exist.  RO assumes data moved already.
         long check = MessageCode.RO_DB_DOESNT_EXIST.getLong();
-
+        // TODO: Current testing doesn't have ability to check a filesystem, which this test relies on.
+        // This test is expected to fail at this point.
         assertEquals("Return Code Failure: " + rtn + " doesn't match: " + check * -1, check * -1, rtn);
 
     }