NPE on SQL with ALIGNED and no WD's.

Added Translation Type to the CLI Options.

Author: dstreev

Writerside/topics/Release-Notes.md

@@ -2,31 +2,26 @@
 
 ## Known Issues
 
-The latest set of known issues can be
-found [here](https://github.com/cloudera-labs/hms-mirror/issues?q=is%3Aissue+is%3Aopen+label%3Abug)
+The latest set of known issues can be found [here](https://github.com/cloudera-labs/hms-mirror/issues?q=is%3Aissue+is%3Aopen+label%3Abug)
 
 ## Enhancement Requests
 
-The latest set of enhancement requests can be
-found [here](https://github.com/cloudera-labs/hms-mirror/issues?q=is%3Aissue+is%3Aopen+label%3Aenhancement). 
+The latest set of enhancement requests can be found [here](https://github.com/cloudera-labs/hms-mirror/issues?q=is%3Aissue+is%3Aopen+label%3Aenhancement). 
 
-If there is
-something you'd like to see, add a new issue [here](https://github.com/cloudera-labs/hms-mirror/issues)
+If there is something you'd like to see, add a new issue [here](https://github.com/cloudera-labs/hms-mirror/issues)
 
 ## 2.2.0.15
 
 **What's New**
 
 - Add support for Oracle Metastore Direct Connection
-- [SQL Strategy only uses MSCK for partition discovery for Shadow Table](https://github.
-  com/cloudera-labs/hms-mirror/issues/145)
+- [SQL Strategy only uses MSCK for partition discovery for Shadow Table](https://github.com/cloudera-labs/hms-mirror/issues/145)
 
 **Bugs (Fixed)**
 
 - Output and Report Directory Consistency between CLI and Web UI.  See docs for more details.
 - Postgres Metastore Direct Connection Fixes
-- SQL Data Strategy Validation Blockers for Acid tables
-- 
+- SQL Data Strategy Validation Blockers for Acid tables- 
 
 ## 2.2.0.12
 

pom.xml

@@ -28,7 +28,7 @@
 
     <groupId>com.cloudera.utils.hadoop</groupId>
     <artifactId>hms-mirror</artifactId>
-    <version>2.2.0.14.2</version>
+    <version>2.2.0.15</version>
     <packaging>jar</packaging>
 
     <name>hms-mirror</name>

src/main/java/com/cloudera/utils/hms/mirror/cli/HmsMirrorCommandLineOptions.java

@@ -1259,6 +1259,18 @@ CommandLineRunner configTransferOwnershipTrue(HmsMirrorConfig hmsMirrorConfig) {
         };
     }
 
+    @Bean
+    @Order(1)
+    @ConditionalOnProperty(
+            name = "hms-mirror.config.translation-type")
+    CommandLineRunner configTranslationType(HmsMirrorConfig hmsMirrorConfig, @Value("${hms-mirror.config.translation-type}") String value) {
+        return args -> {
+            log.info("translation-type: {}", value);
+            hmsMirrorConfig.getTransfer().getStorageMigration().setTranslationType(TranslationTypeEnum.valueOf(value.toUpperCase()));
+        };
+    }
+
+
     @Bean
     @Order(1)
     @ConditionalOnProperty(
@@ -1888,6 +1900,12 @@ private Options getOptions() {
         tablePartitionCountFilterOption.setArgName("partition-count");
         options.addOption(tablePartitionCountFilterOption);
 
+        Option translationTypeOption = new Option("tt", "translation-type", true,
+                "Translation Strategy when migrating data. (ALIGNED|RELATIVE)  Default is RELATIVE");
+        translationTypeOption.setRequired(Boolean.FALSE);
+        translationTypeOption.setArgName("translation-type");
+        options.addOption(translationTypeOption);
+
         Option cfgOption = new Option("cfg", "config", true,
                 "Config with details for the HMS-Mirror.  Default: $HOME/.hms-mirror/cfg/default.yaml");
         cfgOption.setRequired(false);

src/main/java/com/cloudera/utils/hms/mirror/cli/HmsMirrorCommandLineOptionsEnum.java

@@ -90,6 +90,7 @@ public enum HmsMirrorCommandLineOptionsEnum {
     TABLE_FILTER_PARTITION_COUNT_LIMIT("tfp", "table-filter-partition-count-limit", "partition-count", ""),
     TABLE_FILTER_SIZE_LIMIT("tfs", "table-filter-size-limit", "size MB", ""),
     TRANSFER_OWNERSHIP("to", "transfer-ownership", null, ""),
+    TRANSLATION_TYPE("tt", "translation-type", "type", ""),
     VIEW_ONLY("v", "views-only", null, ""),
     WAREHOUSE_DIRECTORY("wd", "warehouse-directory", "path", ""),
     WAREHOUSE_PLANS("wps", "warehouse-plans", "db=ext-dir:mngd-dir", "");

src/main/java/com/cloudera/utils/hms/mirror/service/DatabaseService.java

@@ -662,7 +662,7 @@ public boolean buildDBStatements(DBMirror dbMirror) {
                                 break;
                         }
                         // Check the location against the ENV warehouse location.  If they match, don't set the location.
-                        if (nonNull(envWarehouse)) {
+                        if (nonNull(targetManagedLocation) && nonNull(envWarehouse)) {
                             String reducedTargetLocation = NamespaceUtils.getParentDirectory(targetManagedLocation);
                             if (reducedTargetLocation.equals(envWarehouse.getManagedDirectory())) {
                                 // The new target location is the same as the ENV warehouse location.  So we're not