Add error handling and formatting for assemble_cluster_template

Signed-off-by: Webster Mudge <[email protected]>

plugins/action/assemble_cluster_template.py

@@ -1,6 +1,3 @@
-#!/usr/bin/env python
-# -*- coding: utf-8 -*-
-
 # Copyright 2023 Cloudera, Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -189,7 +186,12 @@ def run(self, tmp=None, task_vars=None):
             # Compile the regexp
             compiled = None
             if regexp is not None:
-                compiled = re.compile(regexp)
+                try:
+                    compiled = re.compile(regexp)
+                except re.error as e:
+                    raise AnsibleActionFail(
+                        message=f"Regular expression, {regexp}, is invalid: {to_native(e)}"
+                    )
 
             # Assemble the src files into output file
             with tempfile.NamedTemporaryFile(
@@ -231,15 +233,15 @@ def run(self, tmp=None, task_vars=None):
 
                 if assembled_checksum != dest_stat["checksum"]:
                     diff = {}
-                    
+
                     if self._task.diff:
                         diff = self._get_diff_data(dest, assembled.name, task_vars)
 
                     # Define a temporary remote path for the remote copy
                     remote_path = self._connection._shell.join_path(
                         self._connection._shell.tmpdir, "assembled_cluster_template"
                     )
-                    
+
                     # Transfer the file to the remote path
                     transfered = self._transfer_file(assembled.name, remote_path)
 
@@ -262,7 +264,7 @@ def run(self, tmp=None, task_vars=None):
 
                     if diff:
                         copy.update(diff=diff)
-                    
+
                     result.update(copy)
                 else:
                     # Gather details on the existing file
@@ -271,7 +273,7 @@ def run(self, tmp=None, task_vars=None):
                         module_args=submodule_args,
                         task_vars=task_vars,
                     )
-                    
+
                     result.update(file)
         except AnsibleAction as e:
             result.update(e.result)