Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multistage Dockerfile #103

Open
FlorianIkarus opened this issue Aug 17, 2023 · 2 comments · May be fixed by #112
Open

Allow multistage Dockerfile #103

FlorianIkarus opened this issue Aug 17, 2023 · 2 comments · May be fixed by #112
Assignees

Comments

@FlorianIkarus
Copy link

As much as I understand the reason for verifying the Docker image name in the Dockerfile, the current approach makes multistage Dockerfiles impossible.

Example:

FROM cloudblueconnect/connect-extension-runner:28.7 AS build
...
FROM build AS deploy
...

Please modify the validation in connect/eaas/core/validation/validators/base.py/validate_docker_compose_yml, so that it removes the AS <stage name> part (if existing) of the FROM line and then compares it to the pre-calculated image name.

@FlorianIkarus
Copy link
Author

For further information about multi-staging, please refer to the Docker manual:
https://docs.docker.com/build/building/multi-stage/

@Sainomori Sainomori self-assigned this Aug 28, 2023
@Sainomori
Copy link
Contributor

Hi @FlorianIkarus ,

Thanks for sharing your concern. We're aware of the issue you've highlighted and its impact on multistage Dockerfiles. Our team is actively investigating a solution that provides better support for these scenarios.

Stay tuned for updates as we work to address this. Your feedback is greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants