Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU filter doesn't work properly in some situations #1

Open
Mart17 opened this issue Nov 30, 2018 · 0 comments
Open

ICU filter doesn't work properly in some situations #1

Mart17 opened this issue Nov 30, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@Mart17
Copy link
Contributor

Mart17 commented Nov 30, 2018

"This {{type | icu: 'artwork-book'}}..." won't work, because after converting it to string it'll give
'This {{type | icu: ' 'artwork-book' '}}' (two single quotes instead of one + it changes some double quotes to single ones) and Liquid isn't capable of recognizing this. Not sure why but when it has only symbols, or whitespace but no characters then it works. So this ".. {{type | icu: 'artwork-book'}}" will work. Also when I swap string quotes 'This {{type | icu: "artwork-book"}}' it works. I assume this is only related for /locales, because /tokens will be contain only keys-tokens without additional text like blabla: "{{bla1}}, {{bla2}}".

This doesn't even have to be a problem, it depends how the structure of those yaml contents in /locales will look like.

@Mart17 Mart17 added bug Something isn't working documentation and removed documentation labels Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant