Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] More metadata fields #47

Open
rsevilla87 opened this issue Jul 8, 2024 · 6 comments
Open

[RFE] More metadata fields #47

rsevilla87 opened this issue Jul 8, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@rsevilla87
Copy link
Member

rsevilla87 commented Jul 8, 2024

Add more fields to metadata collection, the ones at https://github.com/cloud-bulldozer/e2e-benchmarking/blob/bf5ac71356e1f128f35cb231ad67e39729837345/utils/index.sh#L183C1-L190C53 can be potentially included

Im not sure about the actual benefits of indexing them along with the tests results though. wdyt @jtaleric @dry923 @afcollins , etc?

cc: @paigerube14 @vishnuchalla

@rsevilla87 rsevilla87 added the enhancement New feature or request label Jul 8, 2024
@rsevilla87 rsevilla87 self-assigned this Jul 8, 2024
@jtaleric
Copy link
Member

jtaleric commented Jul 8, 2024

IMHO having consistency across our metadata would be ideal.

Not sure if there is additional benefit adding the metadata across indexes.

@vishnuchalla
Copy link
Collaborator

IMHO having consistency across our metadata would be ideal.

Not sure if there is additional benefit adding the metadata across indexes.

+1. We should look for options to keep metadata minimal. Replicating it across indexes is not necessary.

@afcollins
Copy link
Member

Im not sure about the actual benefits of indexing them along with the tests results though

If it is information we either are not retaining or is difficult to retrieve from what we do capture, then yes I see the value in capturing.
Then we can filter out runs when we need to.

@vishnuchalla
Copy link
Collaborator

I think we have two things regarding metadata here

  • Adding more necessary metadata for the benchmark results itself.
  • Adding a CLI implementation to capture and publish just CI job related metadata to the perf_scale_ci ES index which e2e does as of today. So that we will have something easy to maintain going forward.

cc: @chentex

@vishnuchalla
Copy link
Collaborator

Appending slack thread link, that captures the overall idea.

@jtaleric
Copy link
Member

Adding a CLI implementation to capture and publish just CI job related metadata to the perf_scale_ci ES index which e2e does as of today. So that we will have something easy to maintain going forward.

One thing to consider after more thought and exploration here... All of our CPT runs use perf_scale_ci index as a "aggregation index". However in our research testing we might not use CPT runs, so we would need a way to isolate runs w/o the "aggregation index", which could be the jobSummary data -- but we would just need to be consistent on where we place this job metadata across our tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants