Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream #1

Open
tsx opened this issue May 1, 2019 · 2 comments
Open

Upstream #1

tsx opened this issue May 1, 2019 · 2 comments

Comments

@tsx
Copy link

tsx commented May 1, 2019

I think this is the upstream: https://github.com/mjs/imapclient

We should merge our fixes and get onto released version.

@cschams
Copy link

cschams commented Nov 14, 2019

I pulled the upstream into a branch (upstream-master) and cherry-picked our changes into it. From what i can see, there were three changes in our repository that were not already accepted into master:

I merged the first two into my upstream-master branch, but did not merge the last one. There is now a timeout argument that should cover this need.

@thomasst, can you look at my branch and the two commits I created? Let me know if i missed anything. If this is the correct approach to prepare this dependency for Python 3, I would appreciate some help setting up and testing this. The version we have been using is 1.0, there have been a lot of changes since then.

https://imapclient.readthedocs.io/en/2.1.0/releases.html

@thomasst
Copy link
Member

This looks good. We'll need to do some testing to make sure that sent email replacement in Close works, and at some point also make Nylas use it. I saw also that there were some changes related to SSL, though I don't expect stuff to break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants