Merge branch 'master' into drogus/spacetime-init

Author: drogus

.cargo/config.toml

@@ -3,3 +3,10 @@ rustflags = ["--cfg", "tokio_unstable"]
 
 [alias]
 bump-versions = "run -p upgrade-version --"
+
+[target.x86_64-pc-windows-msvc]
+# Use a different linker. Otherwise, the build fails with some obscure linker error that
+# seems to be a result of us producing a massive PDB file.
+# I (@bfops) tried a variety of other link options besides switching linkers, but this
+# seems to be the only thing that worked.
+linker = "lld-link"

.github/workflows/ci.yml

@@ -58,12 +58,6 @@ jobs:
           $ErrorActionPreference = 'Stop'
           $PSNativeCommandUseErrorActionPreference = $true
 
-          # Use a different linker. Otherwise, the build fails with some obscure linker error that
-          # seems to be a result of us producing a massive PDB file.
-          # I (@bfops) tried a variety of other link options besides switching linkers, but this
-          # seems to be the only thing that worked.
-          $env:RUSTFLAGS='-Clinker=lld-link'
-
           cargo build -p spacetimedb-cli -p spacetimedb-standalone -p spacetimedb-update
           Start-Process target/debug/spacetimedb-cli.exe -ArgumentList 'start --pg-port 5432'
           cd modules

.github/workflows/csharp-test.yml

@@ -83,15 +83,20 @@ jobs:
           CARGO_TARGET_DIR: demo/Blackholio/server-rust/target
 
       - name: Check quickstart-chat bindings are up to date
-        working-directory: sdks/csharp/examples~/quickstart-chat
+        working-directory: sdks/csharp
         run: |
-          bash ../../tools~/gen-quickstart.sh "${GITHUB_WORKSPACE}"
-          # This was copied from tools/check-diff.sh.
-          # It's required because `spacetime generate` creates lines with the SpacetimeDB commit
-          # version, which would make this `git diff` check very brittle if included.
-          PATTERN='^// This was generated using spacetimedb cli version.*'
-          git diff --exit-code --ignore-matching-lines="$PATTERN" -- . || {
-              echo "Error: quickstart-chat bindings have changed. Please regenerate the bindings and commit them to this branch."
+          bash tools~/gen-quickstart.sh
+          "${GITHUB_WORKSPACE}"/tools/check-diff.sh examples~/quickstart-chat || {
+              echo 'Error: quickstart-chat bindings have changed. Please run `sdks/csharp/tools~/gen-quickstart.sh`.'
+              exit 1
+          }
+
+      - name: Check client-api bindings are up to date
+        working-directory: sdks/csharp
+        run: |
+          bash tools~/gen-client-api.sh
+          "${GITHUB_WORKSPACE}"/tools/check-diff.sh src/SpacetimeDB/ClientApi || {
+              echo 'Error: Client API bindings are dirty. Please run `sdks/csharp/tools~/gen-client-api.sh`.'
               exit 1
           }
 
@@ -101,12 +106,8 @@ jobs:
 
       - name: Check for changes
         run: |
-          # This was copied from tools/check-diff.sh.
-          # It's required because `spacetime generate` creates lines with the SpacetimeDB commit
-          # version, which would make this `git diff` check very brittle if included.
-          PATTERN='^// This was generated using spacetimedb cli version.*'
-          git diff --exit-code --ignore-matching-lines="$PATTERN" -- demo/Blackholio/client-unity/Assets/Scripts/autogen || {
-              echo "Error: Bindings are dirty. Please generate bindings again and commit them to this branch."
+          tools/check-diff.sh demo/Blackholio/client-unity/Assets/Scripts/autogen || {
+              echo 'Error: Bindings are dirty. Please run `demo/Blackholio/server-rust/generate.sh`.'
               exit 1
           }
 
@@ -124,7 +125,12 @@ jobs:
           disown
 
       - name: Run regression tests
-        run: bash sdks/csharp/tools~/run-regression-tests.sh .
+        run: |
+          bash sdks/csharp/tools~/run-regression-tests.sh
+          tools/check-diff.sh sdks/csharp/examples~/regression-tests || {
+              echo 'Error: Bindings are dirty. Please run `sdks/csharp/tools~/gen-regression-tests.sh`.'
+              exit 1
+          }
 
       - name: Publish unity-tests module to SpacetimeDB
         working-directory: demo/Blackholio/server-rust

.github/workflows/typescript-test.yml

@@ -102,14 +102,10 @@ jobs:
       - name: Check for changes
         working-directory: crates/bindings-typescript
         run: |
-          # This was copied from SpacetimeDB/tools/check-diff.sh.
-          # It's required because `spacetime generate` creates lines with the SpacetimeDB commit
-          # version, which would make this `git diff` check very brittle if included.
-          PATTERN='^// This was generated using spacetimedb cli version.*'
-          if ! git diff --exit-code --ignore-matching-lines="$PATTERN" -- examples/quickstart-chat/src/module_bindings; then
+          "${GITHUB_WORKSPACE}"/tools/check-diff.sh examples/quickstart-chat/src/module_bindings || {
             echo "Error: Bindings are dirty. Please generate bindings again and commit them to this branch."
             exit 1
-          fi
+          }
 
       # - name: Start SpacetimeDB
       #   run: |

crates/bindings-csharp/Runtime/Exceptions.cs

@@ -72,6 +72,11 @@ public class NoSpaceException : StdbException
     public override string Message => "The provided bytes sink has no more room left";
 }
 
+public class AutoIncOverflowException : StdbException
+{
+    public override string Message => "The auto-increment sequence overflowed";
+}
+
 public class UnknownException : StdbException
 {
     private readonly Errno code;

crates/bindings-csharp/Runtime/Internal/FFI.cs

@@ -36,6 +36,7 @@ public enum Errno : short
     SCHEDULE_AT_DELAY_TOO_LONG = 13,
     INDEX_NOT_UNIQUE = 14,
     NO_SUCH_ROW = 15,
+    AUTO_INC_OVERFLOW = 16,
 }
 
 #pragma warning disable IDE1006 // Naming Styles - Not applicable to FFI stuff.
@@ -96,6 +97,7 @@ public static CheckedStatus ConvertToManaged(Errno status)
                     Errno.SCHEDULE_AT_DELAY_TOO_LONG => new ScheduleAtDelayTooLongException(),
                     Errno.INDEX_NOT_UNIQUE => new IndexNotUniqueException(),
                     Errno.NO_SUCH_ROW => new NoSuchRowException(),
+                    Errno.AUTO_INC_OVERFLOW => new AutoIncOverflowException(),
                     _ => new UnknownException(status),
                 };
             }

crates/bindings-typescript/src/react/useTable.ts

@@ -368,9 +368,6 @@ export function useTable<
         if (whereClause && !evaluate(whereClause, row)) {
           return;
         }
-        if (tableName === 'message') {
-          console.log('onInsert for messages table:', row);
-        }
         callbacks?.onInsert?.(row);
         if (
           ctx.event !== latestTransactionEvent.current ||
@@ -386,9 +383,6 @@ export function useTable<
         if (whereClause && !evaluate(whereClause, row)) {
           return;
         }
-        if (tableName === 'message') {
-          console.log('onDelete for messages table:', row);
-        }
         callbacks?.onDelete?.(row);
         if (
           ctx.event !== latestTransactionEvent.current ||

crates/bindings/src/table.rs

@@ -1009,7 +1009,7 @@ fn insert<T: Table>(mut row: T::Row, mut buf: IterBuf) -> Result<T::Row, TryInse
             sys::Errno::UNIQUE_ALREADY_EXISTS => {
                 T::UniqueConstraintViolation::get().map(TryInsertError::UniqueConstraintViolation)
             }
-            // sys::Errno::AUTO_INC_OVERFLOW => Tbl::AutoIncOverflow::get().map(TryInsertError::AutoIncOverflow),
+            sys::Errno::AUTO_INC_OVERFLOW => T::AutoIncOverflow::get().map(TryInsertError::AutoIncOverflow),
             _ => None,
         };
         err.unwrap_or_else(|| panic!("unexpected insertion error: {e}"))

crates/cli/src/subcommands/publish.rs

@@ -169,6 +169,7 @@ pub async fn exec(mut config: Config, args: &ArgMatches) -> Result<(), anyhow::E
                 &client,
                 &database_host,
                 &domain.to_string(),
+                host_type,
                 &program_bytes,
                 &auth_header,
                 break_clients_flag,
@@ -275,16 +276,27 @@ pub fn pretty_print_style_from_env() -> PrettyPrintStyle {
 
 /// Applies pre-publish logic: checking for migration plan, prompting user, and
 /// modifying the request builder accordingly.
+#[allow(clippy::too_many_arguments)]
 async fn apply_pre_publish_if_needed(
     mut builder: reqwest::RequestBuilder,
     client: &reqwest::Client,
     base_url: &str,
     domain: &String,
+    host_type: &str,
     program_bytes: &[u8],
     auth_header: &AuthHeader,
     break_clients_flag: bool,
 ) -> Result<reqwest::RequestBuilder, anyhow::Error> {
-    if let Some(pre) = call_pre_publish(client, base_url, &domain.to_string(), program_bytes, auth_header).await? {
+    if let Some(pre) = call_pre_publish(
+        client,
+        base_url,
+        &domain.to_string(),
+        host_type,
+        program_bytes,
+        auth_header,
+    )
+    .await?
+    {
         println!("{}", pre.migrate_plan);
 
         if pre.break_clients
@@ -310,12 +322,15 @@ async fn call_pre_publish(
     client: &reqwest::Client,
     database_host: &str,
     domain: &String,
+    host_type: &str,
     program_bytes: &[u8],
     auth_header: &AuthHeader,
 ) -> Result<Option<PrePublishResult>, anyhow::Error> {
     let mut builder = client.post(format!("{database_host}/v1/database/{domain}/pre_publish"));
     let style = pretty_print_style_from_env();
-    builder = builder.query(&[("pretty_print_style", style)]);
+    builder = builder
+        .query(&[("pretty_print_style", style)])
+        .query(&[("host_type", host_type)]);
 
     builder = add_auth_header_opt(builder, auth_header);
 

crates/client-api/src/routes/database.rs

@@ -701,15 +701,29 @@ pub struct PrePublishParams {
 pub struct PrePublishQueryParams {
     #[serde(default)]
     style: PrettyPrintStyle,
+    #[serde(default)]
+    host_type: HostType,
 }
 
 pub async fn pre_publish<S: NodeDelegate + ControlStateDelegate>(
     State(ctx): State<S>,
     Path(PrePublishParams { name_or_identity }): Path<PrePublishParams>,
-    Query(PrePublishQueryParams { style }): Query<PrePublishQueryParams>,
+    Query(PrePublishQueryParams { style, host_type }): Query<PrePublishQueryParams>,
     Extension(auth): Extension<SpacetimeAuth>,
     body: Bytes,
 ) -> axum::response::Result<axum::Json<PrePublishResult>> {
+    // Feature gate V8 modules.
+    // The host must've been compiled with the `unstable` feature.
+    // TODO(v8): ungate this when V8 is ready to ship.
+    #[cfg(not(feature = "unstable"))]
+    if host_type == HostType::Js {
+        return Err((
+            StatusCode::BAD_REQUEST,
+            "JS host type requires a host with unstable features",
+        )
+            .into());
+    }
+
     // User should not be able to print migration plans for a database that they do not own
     let database_identity = resolve_and_authenticate(&ctx, &name_or_identity, &auth).await?;
     let style = match style {
@@ -723,7 +737,7 @@ pub async fn pre_publish<S: NodeDelegate + ControlStateDelegate>(
                 database_identity,
                 program_bytes: body.into(),
                 num_replicas: None,
-                host_type: HostType::Wasm,
+                host_type,
             },
             style,
         )