Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advice for lein users potentially problematic? #6

Open
lread opened this issue Mar 31, 2023 · 1 comment
Open

Advice for lein users potentially problematic? #6

lread opened this issue Mar 31, 2023 · 1 comment

Comments

@lread
Copy link
Member

lread commented Mar 31, 2023

The README advice for lein users currently recommends doing a lein install.
This might have two negative side effects:

  1. depending on how the folks have setup CI caching, the installed dep might get cached
  2. there is a chance that the wrong version might get selected for the check

So why not recommend a lein jar for lein users instead?

And then we can use the same check usage advice as we do for deps.edn based projects.
@holyjak
Copy link
Collaborator

holyjak commented Mar 31, 2023

Absolutely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holyjak @lread