Skip to content

Commit 8da0107

Browse files
authored
feat(upgrade): Default Ready to Yes (#7425)
1 parent f81aaa8 commit 8da0107

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

.changeset/quick-mirrors-eat.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@clerk/upgrade': patch
3+
---
4+
5+
Default Ready to upgrade? to yes

packages/upgrade/src/cli.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ async function main() {
138138
packageManager: getPackageManagerDisplayName(packageManager),
139139
});
140140

141-
if (isInteractive && !(await promptConfirm('Ready to upgrade?'))) {
141+
if (isInteractive && !(await promptConfirm('Ready to upgrade?', true))) {
142142
renderError('Upgrade cancelled. Exiting...');
143143
process.exit(0);
144144
}

packages/upgrade/src/render.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,16 +44,22 @@ export function renderConfig({ sdk, currentVersion, fromVersion, toVersion, vers
4444
console.log('');
4545
}
4646

47-
export async function promptConfirm(message) {
47+
export async function promptConfirm(message, defaultYes = false) {
4848
const rl = readline.createInterface({
4949
input: process.stdin,
5050
output: process.stdout,
5151
});
5252

5353
return new Promise(resolve => {
54-
rl.question(`${message} (y/n): `, answer => {
54+
const prompt = defaultYes ? `${message} (Y/n): ` : `${message} (y/N): `;
55+
rl.question(prompt, answer => {
5556
rl.close();
56-
resolve(answer.toLowerCase() === 'y' || answer.toLowerCase() === 'yes');
57+
const normalized = answer.trim().toLowerCase();
58+
if (!normalized) {
59+
resolve(defaultYes);
60+
return;
61+
}
62+
resolve(normalized === 'y' || normalized === 'yes');
5763
});
5864
});
5965
}

0 commit comments

Comments
 (0)