feat: rename ClerkAuthProvider to ClerkAuthState to clarify its usage (#100)

Author: slightfoot

packages/clerk_auth/lib/src/clerk_auth/auth.dart

@@ -95,7 +95,7 @@ class Auth {
 
   /// A method to be overridden by extension classes to cope with
   /// updating their systems when things change (e.g. the clerk_flutter
-  /// [ClerkAuthProvider] class)
+  /// ClerkAuth class)
   ///
   void update() {}
 

packages/clerk_auth/test/integration/clerk_api/environment_test.dart

@@ -7,22 +7,22 @@ import '../../test_helpers.dart';
 void main() {
   late final Api api;
   late final TestEnv env;
-  final httpClient = TestHttpClient();
+  final httpService = TestHttpService();
 
   setUpAll(() async {
     env = TestEnv('.env.test');
     api = Api(
       publishableKey: env.publishableKey,
       persistor: Persistor.none,
-      httpService: httpClient,
+      httpService: httpService,
     );
     await setUpLogging(printer: TestLogPrinter(), level: Level.SEVERE);
   });
 
   group('Environment:', () {
     test('can fetch', () async {
       await runWithLogging(() async {
-        httpClient.expect(
+        httpService.expect(
           'GET /v1/environment',
           200,
           '{}',

packages/clerk_auth/test/integration/clerk_api/sign_in_test.dart

@@ -34,7 +34,7 @@ class TestLogPrinter extends Printer {
   }
 }
 
-class TestHttpClient implements HttpService {
+class TestHttpService implements HttpService {
   final _expectations = <String, List<Response>>{};
 
   @override
@@ -51,7 +51,7 @@ class TestHttpClient implements HttpService {
       final resp = resps.removeAt(0);
       return Future.value(resp);
     }
-    throw TestHttpClientError(message: 'No response available for $key');
+    throw TestHttpServiceError(message: 'No response available for $key');
   }
 
   void expect(String key, int status, String body) {
@@ -112,11 +112,11 @@ class TestHttpClient implements HttpService {
   }
 }
 
-class TestHttpClientError extends Error {
-  TestHttpClientError({required this.message});
+class TestHttpServiceError extends Error {
+  TestHttpServiceError({required this.message});
 
   final String message;
 
   @override
-  String toString() => 'TestHttpClientError: $message';
+  String toString() => '$runtimeType: $message';
 }

packages/clerk_auth/test/integration/clerk_api/sign_up_test.dart

@@ -1,7 +1,7 @@
 /// Package that will allow you to authenticate and use Clerk from Flutter code.
 library;
 
-export 'src/clerk_auth_provider.dart';
+export 'src/clerk_auth_state.dart';
 export 'src/utils/clerk_telemetry.dart';
 export 'src/utils/clerk_translator.dart';
 export 'src/widgets/authentication/clerk_authentication_widget.dart';

packages/clerk_auth/test/integration/clerk_api/user_details_test.dart

@@ -9,9 +9,9 @@ import 'package:webview_flutter/webview_flutter.dart';
 /// An extension of [clerk.Auth] with [ChangeNotifier] so that
 /// updates to the auth state can be propagated out into the UI
 ///
-class ClerkAuthProvider extends clerk.Auth with ChangeNotifier {
-  /// Construct a [ClerkAuthProvider]
-  ClerkAuthProvider._({
+class ClerkAuthState extends clerk.Auth with ChangeNotifier {
+  /// Construct a [ClerkAuthState]
+  ClerkAuthState._({
     required super.publishableKey,
     required super.persistor,
     required this.translator,
@@ -21,15 +21,15 @@ class ClerkAuthProvider extends clerk.Auth with ChangeNotifier {
           builder: (context) => loading ?? defaultLoadingWidget,
         );
 
-  /// Create an [ClerkAuthProvider] object using appropriate Clerk credentials
-  static Future<ClerkAuthProvider> create({
+  /// Create an [ClerkAuthState] object using appropriate Clerk credentials
+  static Future<ClerkAuthState> create({
     required String publishableKey,
     clerk.Persistor? persistor,
     ClerkTranslator translator = const DefaultClerkTranslator(),
     clerk.SessionTokenPollMode pollMode = clerk.SessionTokenPollMode.onDemand,
     Widget? loading,
   }) async {
-    final provider = ClerkAuthProvider._(
+    final provider = ClerkAuthState._(
       publishableKey: publishableKey,
       persistor: persistor ??
           await clerk.DefaultPersistor.create(
@@ -71,10 +71,10 @@ class ClerkAuthProvider extends clerk.Auth with ChangeNotifier {
     clerk.Strategy strategy, {
     void Function(clerk.AuthError)? onError,
   }) async {
-    final auth = ClerkAuth.of(context, listen: false);
+    final authState = ClerkAuth.of(context, listen: false);
     final client = await call(
       context,
-      () => auth.oauthSignIn(strategy: strategy),
+      () => authState.oauthSignIn(strategy: strategy),
       onError: onError,
     );
     final url = client?.signIn?.firstFactorVerification?.providerUrl;
@@ -92,13 +92,13 @@ class ClerkAuthProvider extends clerk.Auth with ChangeNotifier {
         if (token case String token) {
           await call(
             context,
-            () => auth.attemptSignIn(strategy: strategy, token: token),
+            () => authState.attemptSignIn(strategy: strategy, token: token),
             onError: onError,
           );
         } else {
-          await auth.refreshClient();
+          await authState.refreshClient();
           if (context.mounted) {
-            await call(context, () => auth.transfer(), onError: onError);
+            await call(context, () => authState.transfer(), onError: onError);
           }
         }
         if (context.mounted) {
@@ -119,15 +119,17 @@ class ClerkAuthProvider extends clerk.Auth with ChangeNotifier {
   }) async {
     T? result;
     try {
-      if (context.mounted) {
+      if (context.mounted && !_loadingOverlay.mounted) {
         Overlay.of(context).insert(_loadingOverlay);
       }
       result = await fn();
     } on clerk.AuthError catch (error) {
       _errors.add(error);
       onError?.call(error);
     } finally {
-      _loadingOverlay.remove();
+      if (_loadingOverlay.mounted) {
+        _loadingOverlay.remove();
+      }
     }
     return result;
   }