Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clrtrust will not handle files with line feeds and tabs in their names #16

Open
busykai opened this issue Apr 14, 2018 · 0 comments
Open

Comments

@busykai
Copy link
Contributor

busykai commented Apr 14, 2018

By the assumptions in the design, clrtrust will not handle files which have line feeds and tabs in their names.

Line feed ('\n') and tab ('\t') characters should not be used internally as field separators. Few places need to be revisited:

  1. Instead of using a variable with multi-line content to store the certificate information (filename and subject hash), an associative array should be used.

  2. Passing filenames to the helper should be done via the command-line instead of pipe.

  3. Commands using find to find the files and feed them to the subsequent command via pipe should be handling the output properly.

While this issue may not have too much of practical impact, it should be addressed to remove this unnecessary limitation on the filenames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant