Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit breaks LUKS on Solus #134

Open
Girtablulu opened this issue Dec 8, 2018 · 10 comments · May be fixed by #240
Open

Commit breaks LUKS on Solus #134

Girtablulu opened this issue Dec 8, 2018 · 10 comments · May be fixed by #240
Labels
bug

Comments

@Girtablulu
Copy link

We had an issue update clr-boot-manger on Solus which broke installs which used LUKS after the system run clr-boot-manager update.

I looked into it and found the commit which is causing this problem on solus

commit ef77136

after I patched this one out, I could update and use v3.1.0 and have no issues sofar on my LUKS test system. (Gonna keep an eye on it, @DataDrake is aware of it)

Another small thing I found was running clr-boot-manager list-kernels on a UEFI system I get an error


[FATAL] cbm (../src/bootloaders/systemd-class.c:L507): sd_class_get_default_kernel Unable to parse loader config
  com.solus-project.current.4.19.7-103

Which does not happen on a GRUB install
@bryteise
Copy link
Member

bryteise commented Dec 8, 2018

Ah you might be hitting things that #129 resolves on listing kernels but that looks different so I'll have to try and bootup a Solus install and try that out. I'm really not sure what is going on with the LUKS breakage right now and I'll need to look into that because this does work for Clear Linux LUKS installs.

@Girtablulu
Copy link
Author

Ah okay, didn't see the PR sorry about that.

DataDrake didn't had time yet to look into it and figure out exactly why this happens, I just confirmed his suspicion that this commit is causing it.

@astrolemonade
Copy link

The sudo clr-boot-manager list-kernels command still shows the error, any fix ?

@bryteise
Copy link
Member

bryteise commented Jun 7, 2019

@cata0309 Not yet sorry X(. Any chance you could paste a copy of the config that is showing the error?

@astrolemonade
Copy link

It is a fresh install, not a personalized config

@bryteise
Copy link
Member

Hrm I seem to having the iso installer crash when running in a VM. Will need to poke at this more X(.

@circlenaut circlenaut mentioned this issue Aug 1, 2019
Open
@circlenaut
Copy link

Hey guys, might my issue be related to this?

@bvdlingen
Copy link

bvdlingen commented Sep 30, 2019 •
edited
Loading

Same error here, not using LUKS

Looks scary but everything works fine.

@dorileo
Copy link
Contributor

dorileo commented Jan 31, 2020

Please can you confirm this is still any issue. Can you please check with a more recent version (not sure the version Solus is shipping these days).

@dorileo dorileo added the bug label Jan 31, 2020
@silkeh
Copy link
Contributor

silkeh commented Jul 29, 2020 •
edited
Loading

I can confirm this is still an issue. The cause seems to be that the glob in the linked commit has the wrong order:

$ ls -1 /sys/block/dm-2/slaves/*{,/slaves/*}/dev
/sys/block/dm-2/slaves/dm-0/dev
/sys/block/dm-2/slaves/dm-0/slaves/nvme0n1p2/dev

The glob should probably be: /sys/block/dm-2/slaves/*{/slaves/*,}/dev

Edit: I have tested CBM with this patch, and it works on both LVM on LUKS and just plain LUKS.

@silkeh silkeh linked a pull request Jul 29, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix LUKS glob order silkeh/clr-boot-manager
7 participants
@bryteise @dorileo @silkeh @bvdlingen @Girtablulu @circlenaut @astrolemonade