-
Notifications
You must be signed in to change notification settings - Fork 5
Add recipient and sender parameters for individual name parts #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! I've added some suggestions and comments.
I think a more appropriate PR title is "Add recipient and sender parameters for individual name parts".
website/content/gateway/api_reference/resources/credits/recipient_information.md
Outdated
Show resolved
Hide resolved
website/content/gateway/api_reference/resources/credits/recipient_information.md
Outdated
Show resolved
Hide resolved
website/content/gateway/api_reference/resources/debits/recipient_information.md
Show resolved
Hide resolved
website/content/gateway/api_reference/resources/credits/credits.md
Outdated
Show resolved
Hide resolved
website/content/gateway/api_reference/resources/debits/sender_information.md
Show resolved
Hide resolved
website/content/gateway/examples/payout_to_cardholder/payout_to_cardholder.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Toft Bay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few additional comments 🙂
website/content/gateway/api_reference/resources/credits/recipient_information.md
Outdated
Show resolved
Hide resolved
website/content/gateway/api_reference/resources/credits/recipient_information.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Toft Bay <[email protected]>
This looks very good to me 👍 We just need to set a date in the change entry. |
New name related parameters will be added:
recipient[first_name]
recipient[middle_name]
recipient[last_name]
sender[first_name]
sender[middle_name]
sender[last_name]
This will in time push for the deprecation of:
card[name]
recipient[name]
sender[name]
We will in a grace period allow for both old and new parameters, but we recommend that you plan the shift as we can't guarantee how long our upstream provider supports the old fields.