Skip to content

Add recipient and sender parameters for individual name parts #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

cbobach
Copy link
Contributor

@cbobach cbobach commented Jun 12, 2025

New name related parameters will be added:

  • recipient[first_name]
  • recipient[middle_name]
  • recipient[last_name]
  • sender[first_name]
  • sender[middle_name]
  • sender[last_name]

This will in time push for the deprecation of:

  • card[name]
  • recipient[name]
  • sender[name]

We will in a grace period allow for both old and new parameters, but we recommend that you plan the shift as we can't guarantee how long our upstream provider supports the old fields.

Copy link
Contributor

@mt-clearhaus mt-clearhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! I've added some suggestions and comments.

I think a more appropriate PR title is "Add recipient and sender parameters for individual name parts".

@cbobach cbobach changed the title Change to name related parameters Add recipient and sender parameters for individual name parts Jun 13, 2025
Copy link
Contributor

@mt-clearhaus mt-clearhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional comments 🙂

@cbobach cbobach requested review from a team and mt-clearhaus July 3, 2025 08:39
@mt-clearhaus
Copy link
Contributor

This looks very good to me 👍 We just need to set a date in the change entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants