Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to older signature like functionality for older versions of Python #137

Open
mandli opened this issue Jul 8, 2019 · 4 comments

Comments

@mandli
Copy link
Member

mandli commented Jul 8, 2019

PR #136 introduced some improvements to runclaw and data.py that are not backwards compatible with older versions of Python. It looks like there is not a clean way to do this so we will have to add some version checking to see what version to use.

@mandli
Copy link
Member Author

mandli commented Jul 10, 2019

This is fixed in branch. This branch still needs to deal with issue in runclaw as well. @bolliger32 we should also look at runclaw to figure what needs to be made backward compatible.

@bolliger32
Copy link
Contributor

@mandli Is there more to runclaw that needs to be made backward compatible? Or did you solve it with PR #136. Couldn't quite tell from the above.

@mandli
Copy link
Member Author

mandli commented Jul 20, 2019

I think that branch has it (mentioned above). Otherwise PR #138 has everything.

@bolliger32
Copy link
Contributor

got it. Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants