Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to support Glossary Data for I-Note creation #376

Open
angrave opened this issue Nov 22, 2022 · 3 comments
Open

Decide how to support Glossary Data for I-Note creation #376

angrave opened this issue Nov 22, 2022 · 3 comments
Assignees

Comments

@angrave
Copy link
Collaborator

angrave commented Nov 22, 2022

How will I Notes add Glossary data?
Currently when a new I-Note is created, all of the scene and caption data is assembled as one giant json object here-
https://github.com/classtranscribe/WebAPI/blob/staging/ClassTranscribeServer/Controllers/EPubsController.cs#L86
Should Glossary data be added to this json too?

@lijiaxi2018
Copy link
Contributor

lijiaxi2018 commented Nov 22, 2022

My proposed approach to add Glossary to the INotes

  • Added a GlossaryDataId in the video table similar to SceneDetectionDataId and PhraseHinterDataId
  • When a new video is uploaded, generate a GlossaryDataId and save the data in the TextData table
  • Added a new controller GetGlossary in the EPubController.cs similar to GetSceneData
  • Update the GetEpubData method by making it also output Glossary data

Hi Professor Angrave, please let me know if you think the proposed method is feasible. If feasible, I will start to implement it. Thank you very much.

@angrave
Copy link
Collaborator Author

angrave commented Nov 22, 2022

Sounds Reasonable. Note GetSceneData is annotated with "[NonAction]"; it's not exposed as an API - to be pedantic it's not a new controller endpoint; instead it is just a helper method used by GetEpubData .

I guess you already know this. I'm just checking we're on the same page.

@lijiaxi2018
Copy link
Contributor

lijiaxi2018 commented Nov 22, 2022

Yes I know that GetSceneData is not an API. Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants