Skip to content

The commit lint is breaking git reviewing flow by forcing contributors rebasing alot #5554

Answered by epage
tesuji asked this question in Q&A
Discussion options

You must be logged in to vote

Note that the lint is optional. The job is not a blocker for merge and the included message says just as much.

I also do not mind a lot of rebases during review. In fact, I generally recommend it.

I'm also not running merge queues and having a "frequently broken" lint that only fails on merge would be even more frustrating for people.

Replies: 1 comment 1 reply

Comment options

You must be logged in to vote
1 reply
@tesuji
Comment options

Answer selected by tesuji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants