Merge pull request #481 from ckrack/feat/redirect-to-created-after-add

feat: redirect to created page after adding hydrometer

Author: ckrack

src/Controller/AddHydrometerController.php

@@ -4,6 +4,7 @@
 
 use App\Command\AddHydrometerCommand;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Messenger\MessageBusInterface;
 use Symfony\Component\Routing\Attribute\Route;
@@ -23,8 +24,6 @@ public function __invoke(): Response
         $addHydrometerCommand = new AddHydrometerCommand($hydrometerId);
         $this->messageBus->dispatch($addHydrometerCommand);
 
-        return $this->render('hydrometer/new_hydrometer.html.twig', [
-            'hydrometer_id' => $hydrometerId,
-        ]);
+        return new RedirectResponse($this->generateUrl('app_created_hydrometer', ['token' => $hydrometerId->__toString()]));
     }
 }

src/Controller/CreatedHydrometerController.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace App\Controller;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Attribute\Route;
+use Symfony\Component\Uid\Ulid;
+
+class CreatedHydrometerController extends AbstractController
+{
+    #[Route('/created/{token}', name: 'app_created_hydrometer')]
+    public function __invoke(Ulid $token): Response
+    {
+        return $this->render('hydrometer/new_hydrometer.html.twig', [
+            'hydrometer_id' => $token,
+        ]);
+    }
+}

tests/BrewingFlowFunctionalTest.php

@@ -36,8 +36,9 @@ protected function getService(string $id): mixed
 
     public function testCanAddHydrometer(): Hydrometer
     {
-        $crawler = self::$client->request('POST', '/new');
-
+        self::$client->request('POST', '/new');
+        $this->assertResponseRedirects();
+        $crawler = self::$client->followRedirect();
         $this->assertResponseIsSuccessful();
         $this->assertSelectorTextContains('h1', 'New hydrometer added ✅');
         $this->assertSelectorTextContains('.example-wrapper', 'Your hydrometer token is: ');