Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable user-select for dialogs #18008

Open
oleq opened this issue Feb 27, 2025 · 0 comments
Open

Re-enable user-select for dialogs #18008

oleq opened this issue Feb 27, 2025 · 0 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:ui type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@oleq
Copy link
Member

oleq commented Feb 27, 2025

📝 Provide a description of the improvement

ATM the dialog component overlay has user-select: none. It has been added during dialog system development to prevent accidental selection when the modal is displayed. It also prevents the user from starting a selection in a dialog and then slipping into editing root, which is handled correctly by the browser but may be distracting.

In reality, this brings more harm than good, though. Features such as Track Changes Preview or Accessibility help set user-select: text on their dialogs to allow basic interactions (e.g. it's logical to copy some of their content, which isn't possible with selection disabled). Regular dialogs such as Media embed should also allow users to select fields' labels (e.g., because they may want to copy and translate them). Blocking selection is a UX anti-pattern here too.

I think that "whitelisting" features one by one is pointless and I propose we leave user-select: none on .ck.ck-dialog-overlay but we re-enable it on .ck.ck-dialog. Otherwise, this will become unmaintainable down the road.


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@oleq oleq added domain:ui/ux This issue reports a problem related to UI or UX. package:ui type:improvement This issue reports a possible enhancement of an existing feature. labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

1 participant