-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional logging during the EmojiRepository
plugin initialization
#17988
Comments
Interesting! I've added the Emoji plugin to my dev project for testing. On my system, it works just fine, but a colleague encounters the following error in his browser console (across different browsers): The only difference we’ve identified so far is that I’m using Windows 11, while my colleague is on Windows 10. I'm using a local emoji dataset ("emoji-picker-element-data": "^1.7.1"): node_modules/emoji-picker-element-data/nl/cldr/data.json Additionally, the issue persists when using the default dataset: https://cdn.ckeditor.com/ckeditor5/data/emoji/16/en.json. Given this, how can I debug the problem to determine what’s causing it? // edit |
The emoji feature detects if the downloaded collection is supported on your machine. In other words, if the inserted emoji will be rendered correctly in the editable area (see #17834). If you're sure that the network resource was downloaded correctly, there is no other way that missing Emoji font on the OS prevents the plugin from initializing the feature. This was the case that @dufipl reproduced today, and spent time figuring out what and why it happens. |
It confirms what I wrote, I think. |
@pomek Okay, so if I understand correctly, the Emoji plugin doesn't work out of the box on Windows 10 because it's missing a required emoji font. To ensure both consistent appearance and availability, I'll need to install an external font like Noto Color Emoji, as mentioned in the documentation. Is that right? |
@Bapawe, I hope installing a font will resolve your issue. |
@Bapawe also try to test the option with a lower unicode emoji version, it's possible that Windows 10 has a font, but a very old one. We host v15 and v16. |
@Witoso I've tested both v15 and v16 without the definitionsUrl option, using the CKEditor 5 CDN. In both cases, the Emoji plugin fails to load, resulting in a Could this be a bug where the entire Emoji plugin isn't loaded on Windows 10, rather than just filtering out unsupported emojis? |
We are investigating, it's possible that the guardrails we put in place are too strict for the older systems. |
📝 Provide a description of the improvement
We should add additional logging during the
EmojiRepository
plugin initialization since something might go wrong during the process related to emojis/fonts etc. Without this plugin being ready, the toolbar item and command are not registered and integrators will see the message that the toolbar item is unavailable without any further clue.While integrating samples on CI that used Ubuntu images we encountered an issue with (as it occurred later) missing font and there were no logs that would help us to determine that was the case.
As we discussed with @pomek, it would be beneficial to add warnings at least if:
This will streamline debugging such kind of issues for integrators.
Definition of Done
EmojiRepository
plugin returns an empty collection.If you'd like to see this improvement implemented, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: