Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

Referenced HttpContext is not guaranteed to be valid. #43

Open
Vycka opened this issue Sep 11, 2020 · 0 comments
Open

Referenced HttpContext is not guaranteed to be valid. #43

Vycka opened this issue Sep 11, 2020 · 0 comments

Comments

@Vycka
Copy link

Vycka commented Sep 11, 2020

protected internal object HttpContext

HttpContext = entry.HttpContext;

There are no guarantees that HttpContext is still gonna be valid when client closes connection.
And at least using it with heavy-loaded Kestrel it seems to be always the case and results logging not working at all.
There are also no guarantees that logging is gonna be used in environment where HttpContext even exists.
And HttpContext here seems to be only used for throwing exceptions and the need of it probably can just be removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant