Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better separation of version update suggestions #33

Open
mikesaelim opened this issue May 3, 2024 · 0 comments
Open

Better separation of version update suggestions #33

mikesaelim opened this issue May 3, 2024 · 0 comments

Comments

@mikesaelim
Copy link
Contributor

I was looking at rubysec/bundler-audit for features from the last couple years to steal be inspired by, and I thought rubysec/bundler-audit#327 was a good idea. Sometimes, an advisory suggests multiple possible gem versions to upgrade to, and each of those suggestions uses a comma-separated format. For example, the advisory says

patched_versions:
  - "~> 5.2.6, >= 5.2.6.2"
  - "~> 6.0.4, >= 6.0.4.6"
  - "~> 6.1.4, >= 6.1.4.6"
  - ">= 7.0.2.2"

When we join these together, we also separate them with a comma, and it becomes hard to understand. bundler-audit settled on wrapping each version spec with single quotes, before joining them with a comma as before. So in this example, you'd get

Solution: upgrade to '~> 5.2.6, >= 5.2.6.2', '~> 6.0.4, >= 6.0.4.6', '~> 6.1.4, >= 6.1.4.6', '>= 7.0.2.2'

Should we copy what bundler-audit is doing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant