-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't create new Volunteer Project on initial install #588
Comments
What is the origin of your install? The installer initially creates the volunteer project table with Curious if you can fully replicate the scenario to see if there is an install or upgrade edge-case that should be addressed. Thanks for reporting! |
Hi @ginkgomzd - thanks for the response! The issue has presented on the following environment:
I don't think this is an edge case. The full recreation steps are:
Specifically noting:
So it looks like the upgrader step you've referred doesn't get executed on an initial install of the extension, only upgrades of existing installations. My system does not offer any database upgrades for the extension. My thoughts are that we need to implement a change to the schema XML files and regenerate entity boilerplate code, to prevent new installs of this extension experiencing this issue. Any upgrades from prior versions should be handled by the upgrade file you refer to. What do you think? Cheers! |
I think you are hitting the issue resolved in v2.4.3: 2.4.1-2 were missing the |
If that's the case, I don't understand how this happens when I clone master. |
indeed, that is the million dollar question. Ah, hmmm, is it possible that check for I appreciate your troubleshooting on this. |
First of all I confirm that the problem is not solved in v2.4.3: the bug is present on new installations (v2.4.3 - Wordpress). I have tested uninstalling and reinstalling the extension, it does not change anything. The The extension being not usable, I tried a workaround while waiting for a bug fix:
which seems to works for now |
@ginkgomzd this is blocking our adoption of CiviCRM as CiviVolunteer is the extension we will be primarily using |
Hi @nasiralamreeki , |
I have experienced this CiviVolunteer (2.4.4) issue observed by @MattTrim1 on a new installation of Wordpress (6.2.2) and CiviCRM (5.62.1) on three Ubuntu 22.04 systems. Two were LAMP one was LEMP. I implemented the workaround provided by @gvigneron and no longer get the error. I looking through the source, I'm wondering if the following changes may resolve this issue: In the file: https://github.com/civicrm/org.civicrm.volunteer/blob/master/sql/auto_install.sql Change (lines 40 and 41)...
To...
Regards. |
@irsbugs do you still have a setup where it is convenient to reproduce this? It would be a big help if you can put tracing into the installer and verify that each step is succeeding. |
Yes - see below.
I don't know how to put tracing into the installer. Maybe you could e-mail me with instructions on how to do this. Today, as a way of testing my hypothesis that the issue is in the CiviVolunteer
...original...
...patched to...
In summary, on the platform that I used, the two edits performed to I'll attach my console log, which is interspersed with statements of what I'm also doing on the browser. FYI: I also encountered this CiviVolunteer issue with a system using nginx 1.18.0 and MariaDB 10.6.12 Regards, Ian. |
@irsbugs I greatly appreciate the offer to test. |
I'm sorry, but I don't know what you mean by the "tagged release" of CiviVolunteer. To summarise what I've done, so far: On three separate PC's I've performed clean installs of Ubuntu, Wordpress and CiviCRM. In two cases I used Apache2 and MySQL, in the other case I used nginx and MariaDB. In all three cases I then used the CiviCRM Administer -> System Settings -> Extension and used the "Add New" and "Extension" tabs in performing the download and installation of Angular Profiles 1.2.2 and CiviVolunteer 2.4.4. After completing these installations I then experienced the issue when performing a "Save and Done" in Volunteers -> New Volunteer Project. I also used an AWS ARM arch t4g.small instance with Ubuntu, Apache2, and MySQL Wordpress, CiviCRM and installed Angular Profiles 1.2.2 and CiviVolunteer 2.4.4. This also experienced the issue. In all the above cases I was able to successfully save a new CiviVolunteer project by applying the @gvigneron workaround. Regarding...
...note that in my above four cases CiviVolunteer was not uninstalled and then reinstalled. It was only installed. Yesterday I used one of my PC's and a clean SSD to install Ubuntu, Wordpress, CiviCRM, Apache2, MySQL, and Angular Profiles. I then manually installed CiviVolunteer original version and my patched version. In three cases the original version failed and in three cases the patched version saved a New Volunteer Project OK. If you would like to provide me with a "tagged release" of CiviVolunteer as a zip file, then I'd be happy to do a manual install on a clean system and test it out. cheers, Ian. |
I'm seeing what looks like the same issue on dmaster and locally with the same set up (master on D7). Not doing anything other than trying to create a project. To replicate
Immediately on page load I'm seeing the following in the console:
On clicking Save or Continue, I get: |
Looking into the details a bit, it looks like If these fields shouldn't actually be required, then that should be fixed in the XML here and the sql files can be regenerated from that. But I don't know enough about CiviVolunteer to say if that might have knock-on effects elsewhere. I can submit a PR with this change if required. |
This should be fine to do, updating the XML was just missed in the past. Here's a PR for a start (doing what @MattTrim1 proposed on opening this issue), but some work will be required to upgrade the extension with civix so that the sql and DAO can be regenerated. It's also possible that other steps included in volunteer_upgrade_2.0.sql are needed, but I hope not! |
My PR is now ready to go. |
Any progress on this? The extension is essentially broken on a clean install which doesn't inspire confidence. Many users won't get as far as looking at this page. |
I have a fresh install of CiviVolunteer on a Drupal 10 site and I have hit this issue. |
I am having the same issue Wordpress (6.7.1), CiviCRM 5.79.0 |
using the data earlier in the thread, I fixed mysql> alter table civicrm_volunteer_project modify entity_id int unsigned NULL; mysql> alter table civicrm_volunteer_project modify entity_table varchar(64) NULL; |
I am performing the following steps from the documentation: https://docs.civicrm.org/volunteer/en/latest/projects/#stand-alone
When I submit the settings form, I receive an on-screen error message:
Looking at the logs, it appears that the technical error message being generated is (output response shortened for brevity):
Looking at the schema file for a Project I can see that
entity_table
andentity_id
are required fields. I would be able to submit a PR that changes therequired
value on these fields on these fields tofalse
and regens the entity boilerplate if this is deemed an appropriate solution. It's worked in my testing and allows me to create a new Standalone Project.We may also need an Upgrader script that removes the "NOT NULL" from existing installs.
The text was updated successfully, but these errors were encountered: