Support recent versions of THREE

[sguimmara]

Recent version of THREE.js have some breaking changes that impact this loader. Here is a short list of changes that might be of interest in cityjson-threejs-loader:

• v152 introduces colorspace management
• v155 introduces physical lighting changes
• v163 drops support for WebGL 1

[liberostelios]

Hi @sguimmara.

Thank you so much for reporting this 🙌 And apologies for the late response.

Indeed, the library is now breaking with recent versions of three.js. I have them in my radar and planning on addressing them soon.

[liberostelios]

@sguimmara

de6628b is addressing the issue regarding changes in colorspace management. Therefore the library is now expected to work with v165.

I have not spotted any issues with the the other two issues: light changes should affect the setup of the renderer and scene on the client side, rather than this library. Am I missing something? Any suggestions?

[sguimmara]

For the color space change, you might want to check that colors set on the materials generated by the library look the same before and after the upgrade. If they don't, it means that their color space is not correct. We had this issue when working with Giro3D