Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research using presigned URLs for uploading audio to S3 #36

Open
citomcclure opened this issue Jun 15, 2024 · 1 comment
Open

Research using presigned URLs for uploading audio to S3 #36

citomcclure opened this issue Jun 15, 2024 · 1 comment
Labels
spike Research for features with lots of unknowns voice note Issue directly related to Voice Note feature

Comments

@citomcclure
Copy link
Owner

citomcclure commented Jun 15, 2024

https://docs.aws.amazon.com/AmazonS3/latest/userguide/PresignedUrlUploadObject.html

Using presigned URLs will have several benefits, including:

  • Faster performance since we are note sending audio through HTTPs, decoding, parsing, validating audio format, and then writing to temp before finally uploading to S3
  • Current max Lambda invocation payload size is 6MB
    • AWS Lambda documentation here
    • and since audio is getting Base64 encoded, it's more like 4.2-4.4MB according to this
  • Will make updating notes with additional transcription (see scope change here Voice notes #26 ) implementation much easier since we will be able to send data in HTTP now (like dateCreated field)
  • typically considered the "correct" way to do it and is prone to less mistakes
  • will make it easier for researching Research optimizing media file format for transcriptions #33
@citomcclure citomcclure added voice note Issue directly related to Voice Note feature spike Research for features with lots of unknowns labels Jun 15, 2024
@citomcclure
Copy link
Owner Author

If unable to implement presigned URLs, easier (but smaller) optimization is to stream audio directly to S3 instead of creating and saving a file to execution environment (i.e., temp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike Research for features with lots of unknowns voice note Issue directly related to Voice Note feature
Projects
Status: To Do
Development

No branches or pull requests

1 participant