Pool size increase: MaxDoorExtensions

[kamelzarandah]

What happened?

MaxDoorExtensions value="320"
if possible can we also get this pool size, as of right now, exceeding this one also causes an instant crash
RDR2_b1491.exe!?Entities_Create@fwMapDataContents@rage@@s?_PPAVfwMapData@rage@@PAVfwMapDataContents@Entities_Create@@h@Z (0x10a)

Door extensions crash (if you have to many Door extensions in ymap or ytyp Files)

something like this happens when you have many big apartment buildings for example in Saint Denis where all the big buildings are next to each other

Expected result

ability to add more doors without crashing

Reproduction steps

a few maps with doors next to each other will result in a pool size crash related to MaxDoorExtensions

Importancy

Crash

Area(s)

RedM, FXServer

Specific version(s)

redm/ windows 10573

Additional information

increasing this pool size can help with the task of opening up the whole map with mlo's and ymaps

[LandminenTester]

I support this!

[SevenLife]

I support it too ! Like custom/edited AMV pool size limit ! they need to be raised please

[farsey87]

yes please

[Masterspooni]

I support this!

[iSn4x]

Yes, pls let us pick the pool sizes we need

[M8-4-Life]

Need this please, definitely support this!

[boysandghouls42]

Definitely support this! We desperately need this.

[BlackLegion23]

Absolutly supporting this

[Perla39]

I support this!

[outsider31000]

@kamelzarandah according to the list https://content.cfx.re/mirrors/client/pool-size-limits/redm.json this wasn't added yet, but I think its possible to increment using the new features to increase the pool sizes, have you tried ?

@Nobelium-cfx is it possible to add this to the list? or it is not required anymore?
other wise should be good to close this issue.

[Nobelium-cfx]

@kamelzarandah according to the list https://content.cfx.re/mirrors/client/pool-size-limits/redm.json this wasn't added yet, but I think its possible to increment using the new features to increase the pool sizes, have you tried ?

@Nobelium-cfx is it possible to add this to the list? or it is not required anymore? other wise should be good to close this issue.

From a quick look to it - it seems that MaxDoorExtensions pool is not natively supported by increase-pool-size command. It uses the same mechanism as Pool Monitor and I don't see MaxDoorExtensions there.

But again - it's just a quick look and I may be wrong. You can use the local experiments feature (https://docs.fivem.net/docs/server-manual/server-commands/#local-experiments), try to increase it locally and see if it actually works.

If it does - let me know, we will add it to the allow list then.

If not - we would either need to take a closer look at how to add support for it, or just try to increase it in https://github.com/citizenfx/fivem/blob/master/data/client_rdr/citizen/common/data/gameconfig.xml . Second is probably more pragmatic approach. So then feel free to make a PR increasing it in (linking this discussion).

PS: sorry for not responding earlier, I postponed this issue, but busy with other things and forgot about it.

[outsider31000]

@Nobelium-cfx not sure how to test if it increases or not since this doesnt exist in the pool monitor to visually see the max items
unless there's a way to get the max items that I'm not aware of?

I have also made a pr #3141 to add it to the list

[Identity-labs]

All pools are available in pool monitor, but not all pools have name hash.
Check if jooat of MaxDoorExtensions is present, if not MaxDoorExtensions is not a valid pool name

[outsider31000]

All pools are available in pool monitor, but not all pools have name hash. Check if jooat of MaxDoorExtensions is present, if not MaxDoorExtensions is not a valid pool name

CPed and CObject also do not show there theres only CVehicle

[Identity-labs]

because it's Peds and Objects

[outsider31000]

because it's Peds and Objects

but why using GetGamePool("CPed") works ? and Peds dont ?

thats what I am confused same happens for CObject

[Identity-labs]

Because it's hardcoded in fivem code
https://github.com/citizenfx/fivem/blob/master/code/components/extra-natives-five/src/PoolTraversalNatives.cpp#L289

[outsider31000]

its confusing then using CPeds when its called Peds in the Pool monitor

But they still dont show on the monitor Pool those 2 that I mentioned, only Peds show not even Objects show

[outsider31000]

ah its Object not Objects

[outsider31000]

yeah this name MaxDoorExtensions doesn't seem to be a valid pool name

@Nobelium-cfx the hash though is most likely this one 0xb4e04aa4 since is the only pool with max items 320

[Gogsi]

Yes it is that one. The name of the pool is CDoorExtension.

MaxDoorExtension is just the name of the field that the parser reads from gameconfig.xml to get the vanilla value for the CDoorExtension pool size. https://alexguirre.github.io/rage-parser-dumps/dump.html?build=1491&game=rdr3#CExtensionConfig

I'm not sure where the 320->350 discrepancy comes from. Maybe different builds?
EDIT: for some reason these ConfigExtensions are defined 3 times in gameconfig.xml and the last value is 320

[outsider31000]

oh nice, yeah its missing on the list ill adjust my pr then thanks

[Gogsi]

All of this also applies to V where the pool only has a size of 64 btw. Though, I don't think I've heard complaints about it there for some reason

[Nobelium-cfx]

not sure how to test if it increases or not since this doesnt exist in the pool monitor to visually see the max items
unless there's a way to get the max items that I'm not aware of?

I was thinking about adding it and then checking if crashes reported in this bug reappear. But trying to add the name to the poolEntriesTable is also ok.

Yes it is that one. The name of the pool is CDoorExtension.

Oh, thank you @Gogsi ! I checked Joaat hash - but only for MaxDoorExtension (couldn't find and decided it's just allocated differently), didn't think of trying other CDoorExtension. Hash 0xb4e04aa4 is indeed in the list.

Ok, so then we can add CDoorExtension to poolEntriesTable list and the allow increasing CDoorExtension through increase-pool-size. I'll make a commit and reply here once it gets merged.

[outsider31000]

#3142
The pr is here with the correct name btw @Nobelium-cfx
And thank you.

[Nobelium-cfx]

CDoorExtension should be added to Canary soon with 8871b05 . Also updated https://content.cfx.re/mirrors/client/pool-size-limits/redm.json to allow increasing CDoorExtension by up to 160.

So it should be all done now. Feel free to reopen the issue if I missed something.

[kamelzarandah]

CDoorExtension should be added to Canary soon with 8871b05 . Also updated https://content.cfx.re/mirrors/client/pool-size-limits/redm.json to allow increasing CDoorExtension by up to 160.

So it should be all done now. Feel free to reopen the issue if I missed something.

is it possible to take a look at CPropSetObjectExtension pool size, this would be the last one causing crashes for us at least. attached is the image of the crash when this pool size is full. its a very common crash for us. the pool increases with the number of props in the prop set it seems

thank you so much for the effort, you and everyone who contributed to this thread! you guys make a huge difference everyday

[outsider31000]

for context this pool seems to increase with the amount of entities a propset has when spawned
so having lots of propsets in one place can lead to a crash if they contain many entities (which they do)

so yeah would be usefull if this is aplied to the list @Nobelium-cfx
thanks

[Nobelium-cfx]

@kamelzarandah Looks good. Done.

PS: It may take a few hours for the change to propagate.

[kamelzarandah]

what would be the new max size ?

[Nobelium-cfx]

what would be the new max size ?

Currently you can increase it by 450. So 1400 in total.