From aa673d15579571c8286051f7dbade5a05851d104 Mon Sep 17 00:00:00 2001 From: Rich Logan Date: Thu, 4 Jul 2024 14:58:49 +0100 Subject: [PATCH 1/3] Add go as action dependency `go` is a required for BoringSSL builds --- .github/actions/prepare-build/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/prepare-build/action.yml b/.github/actions/prepare-build/action.yml index e461e219..449c9117 100644 --- a/.github/actions/prepare-build/action.yml +++ b/.github/actions/prepare-build/action.yml @@ -31,7 +31,7 @@ runs: if: ${{ runner.os == 'macOS' }} shell: bash run: | - brew install llvm pkg-config nasm + brew install llvm pkg-config nasm go ln -s "/usr/local/opt/llvm/bin/clang-format" "/usr/local/bin/clang-format" ln -s "/usr/local/opt/llvm/bin/clang-tidy" "/usr/local/bin/clang-tidy" From 34e94cb6bb47392912f4fb55c965e81d6b2f2b51 Mon Sep 17 00:00:00 2001 From: Rich Logan Date: Mon, 8 Jul 2024 09:56:56 +0100 Subject: [PATCH 2/3] Use ctest --- .github/workflows/main_ci.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/main_ci.yml b/.github/workflows/main_ci.yml index 0751b5c0..51833d11 100644 --- a/.github/workflows/main_ci.yml +++ b/.github/workflows/main_ci.yml @@ -58,15 +58,9 @@ jobs: cmake -B "${{ env.BUILD_DIR }}" -DVCPKG_MANIFEST_DIR="${{ env.CRYPTO_DIR }}" -DTESTING=ON cmake --build "${{ env.BUILD_DIR }}" - - name: Unit Test (non-Windows) - if: matrix.os != 'windows-latest' + - name: Unit Test run: | - cmake --build "${{ env.BUILD_DIR }}" --target test - - - name: Unit Test (Windows) - if: matrix.os == 'windows-latest' - run: | - cmake --build "${{ env.BUILD_DIR }}" --target RUN_TESTS + ctest --test-dir "${{ env.BUILD_DIR }}" interop-test: if: github.event.pull_request.draft == false From 93a02d84248a244f3a3df0d26127171eb0457cc4 Mon Sep 17 00:00:00 2001 From: Rich Logan Date: Mon, 8 Jul 2024 10:10:50 +0100 Subject: [PATCH 3/3] Use runner context variable directly --- .github/workflows/main_ci.yml | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/workflows/main_ci.yml b/.github/workflows/main_ci.yml index 51833d11..9a7841f1 100644 --- a/.github/workflows/main_ci.yml +++ b/.github/workflows/main_ci.yml @@ -38,7 +38,6 @@ jobs: crypto: [openssl_1.1, openssl_3, boringssl] env: - BUILD_DIR: "${RUNNER_TEMP}/build_${{ matrix.crypto }}" CRYPTO_DIR: "./alternatives/${{ matrix.crypto }}" steps: @@ -55,12 +54,12 @@ jobs: - name: Build run: | - cmake -B "${{ env.BUILD_DIR }}" -DVCPKG_MANIFEST_DIR="${{ env.CRYPTO_DIR }}" -DTESTING=ON - cmake --build "${{ env.BUILD_DIR }}" + cmake -B "${{ runner.temp }}/build_${{ matrix.crypto }}" -DVCPKG_MANIFEST_DIR="${{ env.CRYPTO_DIR }}" -DTESTING=ON + cmake --build "${{ runner.temp }}/build_${{ matrix.crypto }}" - name: Unit Test run: | - ctest --test-dir "${{ env.BUILD_DIR }}" + ctest --test-dir "${{ runner.temp }}/build_${{ matrix.crypto }}" interop-test: if: github.event.pull_request.draft == false @@ -69,7 +68,6 @@ jobs: runs-on: ubuntu-latest env: - BUILD_DIR: "${RUNNER_TEMP}/build_openssl_1.1" CRYPTO_DIR: "./alternatives/openssl_1.1" steps: @@ -86,8 +84,8 @@ jobs: - name: Build run: | - cmake -B "${{ env.BUILD_DIR }}" -DVCPKG_MANIFEST_DIR="${{ env.CRYPTO_DIR }}" - cmake --build "${{ env.BUILD_DIR }}" + cmake -B "${{ runner.temp }}/build_openssl_1.1" -DVCPKG_MANIFEST_DIR="${{ env.CRYPTO_DIR }}" + cmake --build "${{ runner.temp }}/build_openssl_1.1" - name: Build (Interop Harness) run: | @@ -118,7 +116,6 @@ jobs: crypto: [openssl_1.1, openssl_3, boringssl] env: - BUILD_DIR: "${RUNNER_TEMP}/build_${{ matrix.crypto }}" CRYPTO_DIR: "./alternatives/${{ matrix.crypto }}" steps: @@ -135,6 +132,6 @@ jobs: - name: Build with clang-tidy run: | - cmake -B "${{ env.BUILD_DIR }}" -DVCPKG_MANIFEST_DIR="${{ env.CRYPTO_DIR }}" \ - -DTESTING=ON -DCLANG_TIDY=ON -DSANITIZERS=ON - cmake --build "${{ env.BUILD_DIR }}" + cmake -B "${{ runner.temp }}/build_${{ matrix.crypto }}" -DVCPKG_MANIFEST_DIR="${{ env.CRYPTO_DIR }}" \ + -DTESTING=ON -DCLANG_TIDY=ON -DSANITIZERS=ON + cmake --build "${{ runner.temp }}/build_${{ matrix.crypto }}"