Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update config options for crypto backend #697

Open
pabuhler opened this issue Apr 1, 2024 · 2 comments
Open

update config options for crypto backend #697

pabuhler opened this issue Apr 1, 2024 · 2 comments
Milestone

Comments

@pabuhler
Copy link
Member

pabuhler commented Apr 1, 2024

Wrong things will happen if you enable two or more of --enable-openssl, --enable-wolfssl, and --enable-nss, and I think we have nothing that guards against this. This isn't a new problem with wolfssl (it was already a problem with just openssl and nss), but should we have something to protect against this?

Or possibly even change the configure option syntax to --enable-crypto=[openssl,wolfssl,nss] with the 3.0 release, since that's where we're putting other breaking changes.

Originally posted by @JonathanLennox in #692 (comment)

@pabuhler pabuhler added this to the Version 3.0 milestone Apr 1, 2024
@SudhirKesti
Copy link

SudhirKesti commented Dec 21, 2024

I am happy to add this feature in automake, meson, and Cmake. There is no option for me to create branch.
@pabuhler Can you please help me here.

~Sudhir

@pabuhler
Copy link
Member Author

@SudhirKesti , the normal way to do this is to fork the repo and there create a branch in the fork. After wards you can create a PR to merge that branch in to our repo.
This is a pretty standard way of doing things, if you search online I am sure you will find some better explanations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants