Skip to content

Commit ecccb22

Browse files
committed
Merge github.com:cisagov/skeleton-docker into lineage/skeleton
2 parents f6712ec + eafe720 commit ecccb22

File tree

5 files changed

+19
-35
lines changed

5 files changed

+19
-35
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -414,16 +414,14 @@ jobs:
414414
path: ${{ env.BUILDX_CACHE_DIR }}
415415
restore-keys: |
416416
${{ env.BASE_CACHE_KEY }}
417-
- name: Create cross-platform support Dockerfile-x
418-
run: ./buildx-dockerfile.sh
419417
- name: Build and push platform images to registries
420418
id: docker_build
421419
uses: docker/build-push-action@v6
422420
with:
423421
cache-from: type=local,src=${{ env.BUILDX_CACHE_DIR }}
424422
cache-to: type=local,dest=${{ env.BUILDX_CACHE_DIR }}
425423
context: .
426-
file: ./Dockerfile-x
424+
file: ./Dockerfile
427425
labels: ${{ needs.prepare.outputs.labels }}
428426
platforms: |
429427
linux/386

README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,19 @@ docker run cisagov/code-gov-update:0.3.0-rc.4
3636

3737
### Running with Docker Compose ###
3838

39-
1. Create a `docker-compose.yml` file similar to the one below to use [Docker Compose](https://docs.docker.com/compose/).
39+
1. Create a `compose.yml` file similar to the one below to use [Docker Compose](https://docs.docker.com/compose/).
4040

4141
```yaml
4242
---
43-
version: '3.7'
43+
name: code-gov-update
4444

4545
services:
4646
update:
47-
image: cisagov/code-gov-update:0.3.0-rc.4
48-
init: true
4947
environment:
5048
- AWS_CONFIG_FILE=path/to/aws_config
5149
- AWS_PROFILE=default
50+
image: cisagov/code-gov-update:0.3.0-rc.4
51+
init: true
5252
```
5353
5454
1. Start the container and detach:
@@ -78,11 +78,11 @@ environment variables. See the
7878
Please see the [documentation](https://github.com/LLNL/scraper#config-file-options)
7979
for creating your own `scraper.json` configuration file.
8080

81-
1. Then add the secrets to your `docker-compose.yml` file:
81+
1. Then add the secrets to your `compose.yml` file:
8282

8383
```yaml
8484
---
85-
version: '3.7'
85+
name: code-gov-update
8686
8787
secrets:
8888
aws_config:
@@ -92,16 +92,16 @@ environment variables. See the
9292
9393
services:
9494
update:
95+
environment:
96+
- AWS_CONFIG_FILE=/run/secrets/aws_config
97+
- AWS_PROFILE=default
9598
image: cisagov/code-gov-update:0.3.0-rc.4
9699
init: true
97100
secrets:
98101
- source: aws_config
99102
target: aws_config
100103
- source: scraper_config
101104
target: scraper_config.json
102-
environment:
103-
- AWS_CONFIG_FILE=/run/secrets/aws_config
104-
- AWS_PROFILE=default
105105
```
106106

107107
## Updating your container ##
@@ -161,9 +161,9 @@ If you want to add or remove dependencies you would update the `src/Pipfile` fil
161161
and then update dependencies as you would above.
162162

163163
> [!NOTE]
164-
> You should only specify packages that are explicitly needed for your Docker
165-
> configuration. Allow [Pipenv] to manage the dependencies of the specified
166-
> packages.
164+
> You should only specify packages that are direct requirements of
165+
> your Docker configuration. Allow [Pipenv] to manage the dependencies
166+
> of the specified packages.
167167

168168
## Image tags ##
169169

buildx-dockerfile.sh

Lines changed: 0 additions & 15 deletions
This file was deleted.
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
2-
version: '3.7'
2+
# This Docker composition file is used to build and test the container
33

4-
# This docker-compose file is used to build and test the container
4+
name: code-gov-update
55

66
secrets:
77
aws_config:
@@ -14,13 +14,13 @@ services:
1414
build:
1515
context: .
1616
dockerfile: Dockerfile
17+
environment:
18+
- AWS_CONFIG_FILE=/run/secrets/aws_config
19+
- AWS_PROFILE=default
1720
image: cisagov/code-gov-update
1821
init: true
1922
secrets:
2023
- source: aws_config
2124
target: aws_config
2225
- source: scraper_config
2326
target: scraper_config.json
24-
environment:
25-
- AWS_CONFIG_FILE=/run/secrets/aws_config
26-
- AWS_PROFILE=default

requirements-dev.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
--requirement requirements-test.txt
22
ipython
33
pipenv
4+
# The bump-version script requires at least version 3 of semver.
45
semver>=3

0 commit comments

Comments
 (0)