Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display customer name and ID on the reports #515

Open
2 tasks
adhilto opened this issue Dec 4, 2024 · 0 comments
Open
2 tasks

Display customer name and ID on the reports #515

adhilto opened this issue Dec 4, 2024 · 0 comments
Assignees
@k-winters
Labels
enhancement
Milestone
Eel

Comments

@adhilto
Copy link
Collaborator

adhilto commented Dec 4, 2024

💡 Summary

Make it so that ScubaGoggles uses the tenant name and ID instead of just the domain name to identify the tenant.

Motivation and context

ScubaGoggles used to collect all three data points, but we removed the tenant name and ID because those required super admin and we wanted to reduce the permissions required to run ScubaGoggles. However, the new policy API explicitly requires super admin so that objection is now OBE. Bringing them back will make ScubaGoggles output more consistent with ScubaGear and may help users who manage multiple tenants.

Implementation notes

See #152.

Acceptance criteria

  • Customer name is displayed in the report HTML and JSON
  • Customer ID is displayed in the report HTML and JSON
@adhilto adhilto added this to the Eel milestone Dec 4, 2024
@k-winters k-winters self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k-winters k-winters

Labels
enhancement
Projects
None yet
Milestone
Eel
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/515-display-customer-name-and-id-on-the-report cisagov/ScubaGoggles
2 participants
@adhilto @k-winters