Disable MS.SHAREPOINT.3.2v1 functional tests temporarily #1461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Comments out the MS.SHAREPOINT.3.2v1 functional tests until the issue with toggling settings via the API can be resolved.
💭 Motivation and context
Should ensure the scheduled automated functional test runs don't regularly fail due to false positives when the SharePoint API does not toggle the test setting appropriately prior to this test. Long term, pursuing other workarounds and solutions such that these tests can be re-enabled. For now, manual testing is still possible using these tests.
Closes #1459
🧪 Testing
In order the validate that this improves the running of SharePoint functional tests, run the SharePoint PnP variant plan manually and repeat on as many tenants as necessary to ensure it finishes without error.
Can use ScubaGearCheck.ps1 script to automate run with following command line. Assumes that you already have service principal setup and have added thumbprint as default for ScubaGearCheck.ps1 you are running by editing the script.
✅ Pre-approval checklist
All future TODOs are captured in issues, which are referenced in code comments.All relevant repo and/or project documentation updated to reflect these changes.Unit tests added/updated to cover PowerShell and Rego changes.✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Medium
or larger)✅ Post-merge checklist