Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MS.SHAREPOINT.3.2v1 functional tests temporarily #1461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schrolla
Copy link
Collaborator

@schrolla schrolla commented Dec 6, 2024

🗣 Description

Comments out the MS.SHAREPOINT.3.2v1 functional tests until the issue with toggling settings via the API can be resolved.

💭 Motivation and context

Should ensure the scheduled automated functional test runs don't regularly fail due to false positives when the SharePoint API does not toggle the test setting appropriately prior to this test. Long term, pursuing other workarounds and solutions such that these tests can be re-enabled. For now, manual testing is still possible using these tests.

Closes #1459

🧪 Testing

In order the validate that this improves the running of SharePoint functional tests, run the SharePoint PnP variant plan manually and repeat on as many tenants as necessary to ensure it finishes without error.

Can use ScubaGearCheck.ps1 script to automate run with following command line. Assumes that you already have service principal setup and have added thumbprint as default for ScubaGearCheck.ps1 you are running by editing the script.

ScubaGearCheck.ps1 -baseline sharepoint -Tenant 2 -UserAuth:$false -Variant pnp

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@schrolla schrolla added bug This issue or pull request addresses broken functionality Testing This issue or task involves testing the automation tool function labels Dec 6, 2024
@schrolla schrolla added this to the Kraken milestone Dec 6, 2024
@schrolla schrolla self-assigned this Dec 6, 2024
@schrolla schrolla linked an issue Dec 6, 2024 that may be closed by this pull request
@schrolla schrolla marked this pull request as ready for review December 6, 2024 22:16
@schrolla schrolla force-pushed the 1459-disable-misfiring-sharepoint-functional-tests-temporarily branch from f09a437 to d4e31cc Compare December 11, 2024 15:13
@schrolla schrolla modified the milestones: Kraken, Lionfish Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality Testing This issue or task involves testing the automation tool function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable misfiring SharePoint functional tests temporarily
1 participant