Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert workflow testing code to functions #1430

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

james-garriss
Copy link
Collaborator

🗣 Description

These two workflow functions were converted from modules to just functions. There was no change in functionality.

💭 Motivation and context

Closes: #1429

🧪 Testing

Tested via functional tests workflow and the workflow pipeline

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • These code changes follow the ScubaGear [content style guide]
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.
  • Feature branch has been rebased against changes from parent branch, as needed
  • Resolved all merge conflicts on branch
  • Notified merge coordinator that PR is ready for merge via comment mention
  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@james-garriss james-garriss added the enhancement This issue or pull request will add new or improve existing functionality label Nov 15, 2024
@james-garriss james-garriss added this to the Kraken milestone Nov 15, 2024
@james-garriss james-garriss self-assigned this Nov 15, 2024
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the modules converted to scripts because they only had 1 function in them?
If so, you don't need to . source the file. You can remove the function keywords plus associated {} then run the script code directly.

example once the function {} key characters are removed.

./repo/utils/workflow/Install-SeleniumForTesting.ps1

instead of

. repo/utils/workflow/Install-SeleniumForTesting.ps1
Install-SeleniumForTesting

Not a show stopper for this PR. Just a suggestion based on my lack of context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify workflow code to use functions instead of modules
2 participants