Skip to content
This repository has been archived by the owner on Apr 13, 2019. It is now read-only.

Fix checking for unknown options in Configuration #212

Open
dominikh opened this issue Nov 6, 2015 · 0 comments
Open

Fix checking for unknown options in Configuration #212

dominikh opened this issue Nov 6, 2015 · 0 comments
Labels

Comments

@dominikh
Copy link
Member

dominikh commented Nov 6, 2015

In #[] and #[]= we check against a list of known options and raise an exception for unknown options. We assumed that OpenStruct#method_missing would use these methods, but it doesn't. It accesses the data directly. We should either stop using OpenStruct so that we can implement our checks, or we should discard the checks.

The majority of people never experienced the checks, and nobody complained and asked for checks to be added yet, so the use of the checks is questionable at best.

If we do fix the checks, we need to make sure that KnownOptions is correct for all configs. At least :mode for the bot's configuration is missing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant