Add application icon to snap

Author: cimm

README.md

@@ -55,10 +55,10 @@ Some useful notes for the development of this application, not needed to actuall
 
 ### Snapcraft
 
-You'll need [snapcraft](https://snapcraft.io/) to build the snap yourself, the `snapcraft.yaml` file contains the snap build instructions and can be found in the `/snap` directory. Run `snapcraft` from the project's root directory of the project, not from within the `/snap` directory, it will download the necessary dependencies and spit out the snap package. Build on 16.04 since 17.10 seems to have some problems.
+You'll need [snapcraft](https://snapcraft.io/) to build the snap yourself, the `snapcraft.yaml` file contains the snap build instructions and can be found in the `/snap` directory. Run `snapcraft cleanbuild` from the project's root directory of the project, not from within the `/snap` directory, it will download the necessary dependencies and spit out the snap package. You'll need [LXD](https://docs.snapcraft.io/build-snaps/build-on-lxd-docker) to build the snap with cleanbuild (it uses a container).
 
 You can try out the local snap with:
 
 ```bash
-sudo snap install codav_0.1_*.snap --devmode
+snap install codav_0.1_*.snap --dangerous
 ```

snap/snapcraft.yaml

@@ -3,40 +3,29 @@ version: '0.1'
 summary: Reads CODA SEPA payment XML files
 description: |
     An "XML message for Credit Transfer Initiation" (ISO 20022 XML) file encodes European credit transfers (SEPA) in a standard way. It's often refered to as a "CODA (Coded Statement of Account) file". It requests the movement of funds from the debtor account to a creditor. CODAv is a desktop application that understands these electronic messages and serves as a viewer to verify the contents of these files. CODAv follows the Belgian implementation guidelines as defined by the Belgian sector federation Febelfin.
+icon: data/codav.png
 grade: devel # must be 'stable' to release into candidate/stable channels
 confinement: strict
-architectures:
-  - i386
-  - amd64
 
 apps:
   codav:
-    command: desktop-launch codav
-    desktop: share/applications/codav.desktop
+    command: desktop-launch $SNAP/bin/codav
+    desktop: codav.desktop
     plugs:
+      - desktop
       - home
       - x11
-      - unity7
-      - desktop
-      - wayland
 
 parts:
-  gnome-3-26: # needed for Wayland
-    plugin: nil
-    prepare: |
-      apt-get install software-properties-common -y
-      add-apt-repository -y ppa:ubuntu-desktop/gnome-3-26
-      apt-get update
-      apt-get upgrade -yqq
-  desktop-gtk3:
-    after:
-      - gnome-3-26
   codav:
     source: .
     plugin: cmake
     after:
-      - gnome-3-26
       - desktop-gtk3
+    override-build: |
+      snapcraftctl build
+      cp ../../../data/codav.desktop $SNAPCRAFT_PART_INSTALL/codav.desktop
+      sed -i -e 's/Icon=codav/Icon=${SNAP}\/meta\/gui\/icon.png/' $SNAPCRAFT_PART_INSTALL/codav.desktop
     build-packages:
       - valac
       - libxml2-dev