Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PRs with "backport-done/X.Y" into the "done" column for the current version #139

Open
joestringer opened this issue Aug 25, 2023 · 1 comment

Comments

@joestringer
Copy link
Member

When performing the release, occasionally there are PRs in the "needs-backport" column that have the "backport-done/X.Y" label. If the backport is done, these cards should be moved to the "backport done" column in the existing project before closing it.

@joestringer
Copy link
Member Author

I think the background to why this happens is roughly this order of events:

  • Someone creates a backport PR (which gets added to a project)
  • The backport does not land in time for the release
  • A new release is cut, new projects are created, and the branch is updated to point to the new projects in the MLH bot configuration
  • The backport PR gets merged. The labels are updated. However MLH bot doesn't understand that the PR should be moved to the "done" column for the new project because the base branch for the backport PR was from before the release, ie it points to the old closed project.

(Not quite exactly the above, because if this is the case then the PRs would be in the "backport-pending" column of the old project, but the case I observed recently was that PRs with labels "backport-done" were in a new project in the "needs-backport" column.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant