checklist: Add test to avoid filtering separators

There was a bug in the checklist substitution which caused issue content
following a horizontal separator to be discarded rather than posted into
the target issue. Add a test to catch this case.

Signed-off-by: Joe Stringer <[email protected]>

Author: joestringer

cmd/checklist/template_test.go

@@ -6,6 +6,7 @@ package checklist
 import (
 	"os"
 	"path/filepath"
+	"regexp"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -104,3 +105,37 @@ func Test_prepareChecklist(t *testing.T) {
 		})
 	}
 }
+
+func Test_templateToRequest(t *testing.T) {
+	cfg := ChecklistConfig{
+		TargetVer: "v1.10.0-pre.0",
+	}
+	testdataPath := filepath.Join("..", "..", "testdata", "checklist")
+
+	paths, err := filepath.Glob(filepath.Join(testdataPath, "*.input"))
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	for _, path := range paths {
+		_, filename := filepath.Split(path)
+		testname := filename[:len(filename)-len(filepath.Ext(path))]
+
+		t.Run(testname, func(t *testing.T) {
+			source, err := os.ReadFile(path)
+			assert.Nil(t, err, "failed to read input template: ", err)
+
+			barRe := regexp.MustCompile(`---`)
+			expBarCount := len(barRe.FindAll(source, -1)) - 2 // Exclude the metadata section at the top
+
+			cl, err := prepareChecklist(source, cfg)
+			assert.Nil(t, err, "failed to render checklist: ", err)
+
+			req, err := templateToRequest(cl)
+			assert.Nil(t, err, "failed to translate checklist into GitHub request: ", err)
+
+			barCount2 := barRe.FindAllString(*req.Body, -1)
+			assert.Equal(t, len(barCount2), expBarCount, "template unexpectedly removed valid horizontal separators")
+		})
+	}
+}