Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hubble CLI shows superfluous v using --version flag #1613

Open
BlackDex opened this issue Nov 1, 2024 · 1 comment
Open

Hubble CLI shows superfluous v using --version flag #1613

BlackDex opened this issue Nov 1, 2024 · 1 comment
Labels
🐛 kind/bug This is a bug in the Hubble logic.

Comments

@BlackDex
Copy link

BlackDex commented Nov 1, 2024

When running the hubble cli using the --version flag (not documented in the --help though) it shows an extra v in front of the version.
The command version does show it correctly though.

# Using the flag
hubble --version
hubble vv1.16.3

# Using the command
hubble version
hubble v1.16.3@HEAD-5d300c4 compiled with go1.23.2 on linux/amd64
@rolinh rolinh added the 🐛 kind/bug This is a bug in the Hubble logic. label Nov 11, 2024
rolinh added a commit to cilium/cilium that referenced this issue Nov 11, 2024
@rolinh
hubble: consistenly prefix version string with 'v'
186de3f 
Prior to this change, using `hubble --version` and `hubble version`
would produce different results:

    hubble --version # v1.16.3
    hubble version   # 1.16.3

Ref: cilium/hubble#1613

Signed-off-by: Robin Hahling <[email protected]>
@rolinh rolinh mentioned this issue Nov 11, 2024
Merged
@rolinh
Copy link
Member

rolinh commented Nov 11, 2024

Thanks for reporting the issue, it'll be fixed once the PR linked above is merged, backported to the v1.16 branch and then a new Hubble CLI release is created.

rolinh added a commit to cilium/cilium that referenced this issue Nov 15, 2024
@rolinh
hubble: consistenly prefix version string with 'v'
2ddd745 
Prior to this change, using `hubble --version` and `hubble version`
would produce different results:

    hubble --version # v1.16.3
    hubble version   # 1.16.3

Ref: cilium/hubble#1613

Signed-off-by: Robin Hahling <[email protected]>
github-merge-queue bot pushed a commit to cilium/cilium that referenced this issue Nov 20, 2024
@rolinh
hubble: consistenly prefix version string with 'v'
b424bfd 
Prior to this change, using `hubble --version` and `hubble version`
would produce different results:

    hubble --version # v1.16.3
    hubble version   # 1.16.3

Ref: cilium/hubble#1613

Signed-off-by: Robin Hahling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 kind/bug This is a bug in the Hubble logic.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BlackDex @rolinh