-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/policy-names: Add network policy names when they are known. #727
base: master
Are you sure you want to change the base?
Changes from all commits
ba0d54b
05eebce
bd38b66
dd617e1
af3ad60
11c210f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -242,3 +242,29 @@ export const PodEntry = memo<PodItemProps>(function FlowsTableSidebarPodEntry(pr | |||||
</span> | ||||||
); | ||||||
}); | ||||||
|
||||||
export interface PolicyEntryProps { | ||||||
allowedBy: string[]; | ||||||
} | ||||||
|
||||||
export const PolicyEntry = memo<PolicyEntryProps>( | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
function FlowsTableSidebarLabelsEntry(props) { | ||||||
return ( | ||||||
<div className={css.policies}> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
{props.allowedBy.map(policyName => { | ||||||
return <PolicyEntryItem key={policyName} name={policyName} />; | ||||||
})} | ||||||
</div> | ||||||
); | ||||||
}, | ||||||
); | ||||||
|
||||||
export interface PolicyEntryItemProps { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
name: string; | ||||||
} | ||||||
|
||||||
export const PolicyEntryItem = memo<PolicyEntryItemProps>( | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
function FlowsTableSidebarPolicyEntry(props) { | ||||||
return <span className={css.policy}>{props.name}</span>; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
}, | ||||||
); |
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -237,6 +237,12 @@ | |||||||||||
} | ||||||||||||
} | ||||||||||||
|
||||||||||||
.policies { | ||||||||||||
.policy { | ||||||||||||
display: block; | ||||||||||||
} | ||||||||||||
} | ||||||||||||
|
||||||||||||
Comment on lines
+240
to
+245
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Let's use a div, so no need of this. |
||||||||||||
.tcpFlags { | ||||||||||||
.tcpFlag { | ||||||||||||
margin-right: 5px; | ||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.