fix: 404 Not Found error when baseUrl is not / #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinsuki
changed the title
yannikmesserli
approved these changes
Jan 13, 2025
|
Yes, I tested with different root path |
|
The Cypress Cloud is decommissioned, I need to removed it (and possibly migrate to Playwright) let's ignore their failure for now and merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #854
Fix #889
This pull request fixes a bug which hubble-ui will not work if
hubble.ui.baseUrlis specified to other than/.after this pull-request, hubble-ui now correctly consider
<base href>tag (if available) for:${location.origin}/api/)/)side note:
<base href>is changed by cillium's nginx, see https://github.com/cilium/cilium/blob/5a4fdc967a51146c15b65e5401ecb5d7decdd8d2/install/kubernetes/cilium/templates/hubble-ui/_nginx.tpl#L31